test: added rust sdk test for source transformer #1756
Conversation
Signed-off-by: shubham <[email protected]>
shubhamdixit863
changed the title
Signed-off-by: shubham <[email protected]>
Signed-off-by: shubham <[email protected]>
whynowy
changed the title
There was a problem hiding this comment.
E2E should pass once we rebuild & push the image with the protobuf time conversion fix, right? @shubhamdixit863
| transformer: | ||
| container: | ||
| # Filter messages based on event time, see https://github.com/numaproj/numaflow-go/tree/main/pkg/sourcetransformer/examples/event_time_filter | ||
| image: quay.io/numaio/numaflow-rust/source-transformer:stable |
There was a problem hiding this comment.
Naming - we can have multiple source transformer images in the future.
| image: quay.io/numaio/numaflow-rust/source-transformer:stable | |
| image: quay.io/numaio/numaflow-rust/mapt-event-time-filter:stable |
|
@KeranYang we need the same publish scripts for Rust SDK too. |
| http: {} | ||
| transformer: | ||
| container: | ||
| # Filter messages based on event time, see https://github.com/numaproj/numaflow-go/tree/main/pkg/sourcetransformer/examples/event_time_filter |
There was a problem hiding this comment.
wrong link. Please kindly proofread your PRs before marking ready for review. :)
There was a problem hiding this comment.
yeah sure ,thankyou :)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1756 +/- ##
==========================================
+ Coverage 56.86% 56.89% +0.03%
==========================================
Files 216 216
Lines 17350 17350
==========================================
+ Hits 9866 9872 +6
+ Misses 6659 6643 -16
- Partials 825 835 +10 ☔ View full report in Codecov by Sentry. |
Yes its fixed |
What this PR does
This PR introduces a new test for the Rust SDK aimed at ensuring the functionality of the source transformer module. By integrating this test, we aim to maintain high code quality and reliability of the transformations performed by this module.
Fixes -numaproj/numaflow-rs#56
Changes Introduced
The added tests were executed locally to confirm their effectiveness. Results confirm that the new Rust SDK test for the source transformer runs successfully without introducing regressions.