-
Notifications
You must be signed in to change notification settings - Fork 25
Stack trace has no source links #60
Comments
Thanks for the detailed report. We will need to confirm that this is an NUnit issue and not a Visual Studio issue. I am pretty sure it is the later since the code for both is the same. |
The weirdest thing is that the link works when the exception is at the top of the stack (eg. an assertion failed). |
One way that we will be able to confirm if this is an NUnit or Visual Studio issue is to try it using xUnit or MSTests. |
@rprouse Have you ever managed to get 'dotnet-test-mstest' working? It seems to be broken whenever I've tried it. I just assumed they haven't updated it yet for .NET Core 1.0. |
@rprouse I've repeated the steps with Xunit and the stack trace links are working. I believe it is a NUnit-related issue. |
NUnit provides a raw stack trace coming from .NET. It isn't reformatted to be clickable. That would be the job of the gui component that formats it for display. I assume that's the adapter in this case. |
@BalassaMarton Could you try running the same test using TestDriven.Net. Right-click and 'Run Test(s)' inside the test method and double-click on the stack trace in the output window. You can find a preview build here: As @CharliePoole mentions, it's tools that reformat the message to make them clickable or add hyperlinks. They will expect the stacktrace to be in the default format. Let me know if this works. |
I have confirmed this to be the case in the NUnit .NET Core runner. It does not happen in MSTest or in xUnit. The .NET Core runner works correctly if the exception is thrown in the test method, just not in a called method. |
I have also confirmed that this works in the full framework NUnit Adapter, so it is definately a .NET Core Adapter issue. |
This works with the classic .NET Framework version as expected: when a test fails, the stack trace contains clickable links to specific source code locations. However, when running tests on a .NET Core test project, there are no links, only string descriptions of the location of the error.
Steps to reproduce
Class1
:TestClass1
:The text was updated successfully, but these errors were encountered: