Skip to content

fix(resolveCss): use module resolver from kit #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2023
Merged

fix(resolveCss): use module resolver from kit #740

merged 1 commit into from
Oct 25, 2023

Conversation

ineshbose
Copy link
Collaborator

Closes #733 to support usage of pnpm without --shamefully-hoist 😃

@what-the-diff
Copy link

what-the-diff bot commented Oct 22, 2023

PR Summary

  • Implementing Asynchronous Operation in Resolving CSS Path
    Previously, our resolveCSSPath function in module.ts was structured to run synchronously, this meant that the rest of our program had to wait for it to complete before continuing. We have now added the 'await' keyword to this function call, prompting it to operate asynchronously - letting other parts of the program run concurrently while it completes its task.

  • Enhancing Resolver Flexibility with Importing 'tryResolveModule'
    We've made a significant update to the resolvers.ts file. Here, we imported a function called 'tryResolveModule' and used it within an asynchronous resolveCSSPath function. There's now an added capability to try locating the Tailwind CSS file in the package.json. If the module finds it, it will use this file. However, if it doesn't find it, that is not an issue, as it will instead create and utilize a new default Tailwind CSS file. This increases our system's flexibility, making it robust against missing files, and improving its efficiency in handling CSS files.

@atinux atinux merged commit 52356f9 into nuxt-modules:main Oct 25, 2023
Copy link

netlify bot commented Oct 27, 2024

‼️ Deploy request for nuxt-tailwindcss rejected.

Name Link
🔨 Latest commit 23afa3e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for pnpm without shamefully-hoist
2 participants