Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate ocflib.infra.db to ocflib.infra.mysql #141

Closed
abizer opened this issue Oct 2, 2018 · 2 comments · Fixed by #147
Closed

migrate ocflib.infra.db to ocflib.infra.mysql #141

abizer opened this issue Oct 2, 2018 · 2 comments · Fixed by #147

Comments

@abizer
Copy link
Member

abizer commented Oct 2, 2018

as we now have a postgres service, we should rename ocflib.infra.db to ocflib.infra.mysql. it would be a good time to take care of things like #108 as well

@ghost
Copy link

ghost commented Oct 25, 2018

A naive question that might be of poor formatting: after both using find . -type f -exec grep -H 'db' {} \; in my cloned ocflib repo and searching on github with criteria org:ocf ocflib.infra db, there are only three other files referencing that db.py file (namely ocflib/printing/quota.py, ocflib/lab/stats.py, and ocflib/vhost/mail.py). Does it solve this issue if I change the file name to mysql.py and change the references in the three files from db to mysql?

@abizer
Copy link
Member Author

abizer commented Oct 26, 2018

That should work, but you'll also need to migrate any direct calls to db.get_connection in any downstream projects like ocfweb, puppet, utils, etc, as well as in the tests, if there are any. I think there are a few.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant