Paper update #188
Merged
Paper update #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
you can just run "paper" now. no more flags/arguements. also made the "user" arguement optional with "--user" or "-u"
use prompts to set values for non-inputted arguments
fix: make --user optional and include refund/view prompt
|
use something else(TM) |
|
updated to retain original syntax. removed default value for view in favor of prompts. |
RonitNath
approved these changes
Mar 14, 2025
There was a problem hiding this comment.
lgtm. assuming this solves previous issue with argparse, @something please make note of if this isn't the case, otherwise will merge soon
|
also thoughts on removing reason as required? has also been part of discussion about this |
kpengboy
reviewed
Mar 14, 2025
RonitNath
requested changes
Mar 14, 2025
what previous issue are you referring to? @RonitNath |
xa1on
approved these changes
Mar 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hmm so do we break backwards compatibility or use something other than python argparse?