Added tests for the TableMetaDataEntries class #318
+358
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbrunette
requested changes
Mar 25, 2025
| public class TableMetaDataEntriesTest { | ||
|
|
||
| // | ||
| TableMetaDataEntries testMetaDataEntries; |
There was a problem hiding this comment.
Why are TableMetaDataEntries are not private? Do you expect other test classes to access them from a different class?
There was a problem hiding this comment.
No sir. I have made another commit reflecting the required changes.
| private final String TABLE_ID = "testTable"; | ||
| private final String REV_ID = "revId"; | ||
| KeyValueStoreEntry entry1 = new KeyValueStoreEntry(); | ||
| KeyValueStoreEntry entry2 = new KeyValueStoreEntry(); |
There was a problem hiding this comment.
Why are entry1 and entry2 not private? Do you expect other test classes to access them from a different class?
There was a problem hiding this comment.
No sir, new changes have limited access to the test class.
| entry1.aspect = "aspect1"; | ||
| entry1.key = "key1"; | ||
| entry1.type = "number"; | ||
| entry1.value = "value1"; |
There was a problem hiding this comment.
use string constants so you can then reuse string constants in assert statements
| } | ||
|
|
||
|
|
||
| } |
There was a problem hiding this comment.
add a new line to the end of the file
…anges: made testMetaDataEntries private, ENTRY_1,and ENTRY_2 private and final
…ed in tests. Refrectored testAddEntry to check for data integrity.
# Conflicts: # androidlibrary_lib/src/androidTest/java/org/opendatakit/database/data/TableMetaDataEntriesTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses odk-x/tool-suite-X#522 by adding tests for the TableMetaDataEntries and KeyValueStoreEntry classes under data.
Added tests for the TableMetaDataEntries class
testDataBaseInitializationVerifies that the database was created and is empty upon creation.
testAddEntryVerifies that an entry made to the database is successful.
testDescribeContentsTests the content description accuracy.
testWriteToParcelTests that the data written to a parcel is successful and reads the data to make sure data integrity is maintained.
testEntryOrderPreservationVerifies that entries are stored in the order in which they were added.
Added tests for the KeyValueStoreEntry class
testKeyValueStoreEntryInitializationTests that a KeyValueStoreEntry object is initialized correctly and it is empty on creation.
testToStringTests that the content of a KeyValueStoreEntry object is correctly converted to a string.
testHashCodeConsistencyValidates hash code consistency of a KeyValueStoreEntry object and the same instance of that object stored in a parcel.
testHashCodeDifferenceValidates hash code difference of two KeyValueStoreEntry objects.
testEqualsNullValidates of inequality of a KeyValueStoreEntry against a null KeyValueStoreEntry object.
testEqualsSameObjectTest of equality of a KeyValueStoreEntry against itself.
testEqualsDifferentObjectTest for inequality of a KeyValueStoreEntry object against another KeyValueStoreEntry object.
testEqualsTypeMismatchTest for inequality of a KeyValueStoreEntry object against an object of a different type.
testCompareToPartitionVerifies the comparison and sorting of two KeyValueStoreEntry objects based on their partition attributes.
testCompareToAspectVerifies the comparison and sorting of two KeyValueStoreEntry objects based on their aspect attributes.
testCompareToKeyVerifies the comparison and sorting of two KeyValueStoreEntry objects based on their key attributes.
testToCompareEqualityVerifies comparison of equality of two KeyValueStoryEntry objects.
testDescribeContentsTests the content description accuracy.
testWriteToParcelVerifies that the data written to a parcel is successful and reads the data to ensure data integrity is maintained.