-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mailing List Subscribe Option #4191
Open
AlessandroLupo
wants to merge
1
commit into
master-mysterious-egg
Choose a base branch
from
master-mysterious-egg-1-alup
base: master-mysterious-egg
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
d7f0429
to
d0ddd0a
Compare
loco-odoo
reviewed
Mar 14, 2025
...lder/static/src/website_builder/website_mass_mailing/mailing_list_subscribe_option_plugin.js
Outdated
Show resolved
Hide resolved
f40ebad
to
277775b
Compare
loco-odoo
reviewed
Mar 14, 2025
...ml_builder/static/src/website_builder/website_mass_mailing/mailing_list_subscribe_option.xml
Outdated
Show resolved
Hide resolved
...ml_builder/static/src/website_builder/website_mass_mailing/mailing_list_subscribe_option.xml
Outdated
Show resolved
Hide resolved
...ml_builder/static/src/website_builder/website_mass_mailing/mailing_list_subscribe_option.xml
Outdated
Show resolved
Hide resolved
...lder/static/src/website_builder/website_mass_mailing/mailing_list_subscribe_option_plugin.js
Outdated
Show resolved
Hide resolved
277775b
to
ddb40e7
Compare
ddb40e7
to
e5d009f
Compare
loco-odoo
reviewed
Mar 17, 2025
...tml_builder/static/src/website_builder/website_mass_mailing/mailing_list_subscribe_option.js
Outdated
Show resolved
Hide resolved
...lder/static/src/website_builder/website_mass_mailing/mailing_list_subscribe_option_plugin.js
Outdated
Show resolved
Hide resolved
...lder/static/src/website_builder/website_mass_mailing/mailing_list_subscribe_option_plugin.js
Outdated
Show resolved
Hide resolved
...lder/static/src/website_builder/website_mass_mailing/mailing_list_subscribe_option_plugin.js
Outdated
Show resolved
Hide resolved
5dc5673
to
31df7f0
Compare
3ee87bf
to
98b990a
Compare
31df7f0
to
53d2dcb
Compare
53d2dcb
to
a7ee043
Compare
loco-odoo
reviewed
Mar 20, 2025
...static/src/website_builder/website_mass_mailing/newsletter_subscribe_common_option_plugin.js
Outdated
Show resolved
Hide resolved
...lder/static/src/website_builder/website_mass_mailing/mailing_list_subscribe_option_plugin.js
Outdated
Show resolved
Hide resolved
...lder/static/src/website_builder/website_mass_mailing/mailing_list_subscribe_option_plugin.js
Outdated
Show resolved
Hide resolved
...lder/static/src/website_builder/website_mass_mailing/mailing_list_subscribe_option_plugin.js
Outdated
Show resolved
Hide resolved
a7ee043
to
911f206
Compare
loco-odoo
reviewed
Mar 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one last think and it is good for merge 👍 Also do not forget to rebase your PR as it seems that some code merged meanwhile introduced conflicts.
82e8c08
to
69f918f
Compare
69f918f
to
35fa430
Compare
35fa430
to
196d3e6
Compare
196d3e6
to
40fbd5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.