ScrollButton #4195
ScrollButton #4195
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
blse-odoo
force-pushed
the
master-mysterious-egg-3-blse
branch
2 times, most recently
from
ee7c7b0 to
26d95b3
Compare
addons/html_builder/static/src/plugins/scroll_button_option.xml
Outdated
Show resolved
Hide resolved
addons/html_builder/static/src/plugins/scroll_button_option_plugin.js
Outdated
Show resolved
Hide resolved
addons/html_builder/static/src/plugins/scroll_button_option_plugin.js
Outdated
Show resolved
Hide resolved
addons/html_builder/static/src/plugins/scroll_button_option_plugin.js
Outdated
Show resolved
Hide resolved
addons/html_builder/static/src/plugins/scroll_button_option.xml
Outdated
Show resolved
Hide resolved
blse-odoo
force-pushed
the
master-mysterious-egg-3-blse
branch
2 times, most recently
from
b5078a7 to
cd469ad
Compare
addons/html_builder/static/src/plugins/scroll_button_option.xml
Outdated
Show resolved
Hide resolved
addons/html_builder/static/src/plugins/scroll_button_option_plugin.js
Outdated
Show resolved
Hide resolved
| import { _t } from "@web/core/l10n/translation"; | ||
| import { registry } from "@web/core/registry"; | ||
| import { ScrollButtonOption } from "./scroll_button_option"; | ||
| import { classAction } from "@html_builder/core/plugins/core_builder_action_plugin"; |
There was a problem hiding this comment.
Probably ok here as we already do it a lot in the code but I tell you so that you know for the next time: the correct way to do this is to use getActionId() ; that way, if classAction is redefined in website we will have the correct version of it 👍
There was a problem hiding this comment.
I indeed found a lot of examples using classAction directly. I'm ok to do it differently, but I did not find any getActionId (maybe this is another name?)
There was a problem hiding this comment.
yes, it is getAction() 👍 If you are inside a plugin, you can use this.dependencies.builderActions.getAction by adding builderActions in the dependencies of the plugin
| } | ||
| } | ||
| } | ||
| registry.category("website-plugins").add(ScrollButtonOptionPlugin.id, ScrollButtonOptionPlugin); |
There was a problem hiding this comment.
I checked functionally and it seems that there is a problem; if you put the height of the snippet at 100% and then go back to "auto' there is a big blank space remaining, maybe worth having a look 👍
Edit: also note that your runbot is yellow because ScrollButtonOption misses static props description (here static props = {};)
There was a problem hiding this comment.
I noticed 2 bugs that look like what you are describing:
- If we set 100%, then something else, it happens often that the "min-height" on the section set by the fullscreen interaction stays in the dom, and keeps it fullscreen, with blanks around the gallery
- If we set a big height for the gallery (for example by setting 100%), then a smaller height, the interaction ensuring that each element of the gallery has the same height as the tallest one in the gallery keep enforcing the height as before the reduction of size.
Is seems to be the same underlying bug related to how interactions are not properly cleaned when saving a step or something like that. (I have no idea how to fix that)
addons/html_builder/static/src/plugins/scroll_button_option_plugin.js
Outdated
Show resolved
Hide resolved
blse-odoo
force-pushed
the
master-mysterious-egg-3-blse
branch
from
cd469ad to
c2f9246
Compare
FrancoisGe
force-pushed
the
master-mysterious-egg
branch
from
3ee87bf to
98b990a
Compare
blse-odoo
force-pushed
the
master-mysterious-egg-3-blse
branch
3 times, most recently
from
0467eae to
664ae6d
Compare
blse-odoo
force-pushed
the
master-mysterious-egg-3-blse
branch
from
664ae6d to
c67043e
Compare
No description provided.