-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] image_gallery_option: implement slideshow #4213
base: master-mysterious-egg
Are you sure you want to change the base?
Conversation
This commit implement the slideshow speed option: The user can now control the speed in which the slideshow is sliding
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
b169ae3
to
ed95df7
Compare
const container = this.getContainer(imageGalleryElement); | ||
const currentInterval = imageGalleryElement.querySelector(".carousel").dataset.bsInterval; | ||
const carouselEl = imageGalleryElement.querySelector(".carousel"); | ||
const colorContrast = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the part with vcss
=== '002' ?
id: "slideshow_" + new Date().getTime(), | ||
colorContrast, | ||
}); | ||
carouselEl.removeEventListener("slide.bs.carousel", this.onCarouselSlid); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
slide or slid?
This commit add the possibility to add an image in a slideshow gallery. It also add the possibility of reordering images in a slideshow.
ed95df7
to
c3b0ea8
Compare
This commit implement the slideshow speed option:
The user can now control the speed in which the slideshow is sliding