Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] image_gallery_option: implement slideshow #4213

Open
wants to merge 2 commits into
base: master-mysterious-egg
Choose a base branch
from

Conversation

fdardenne
Copy link

This commit implement the slideshow speed option:
The user can now control the speed in which the slideshow is sliding

This commit implement the slideshow speed option:
The user can now control the speed in which the slideshow
is sliding
@robodoo
Copy link

robodoo commented Mar 19, 2025

This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged.

@fdardenne fdardenne changed the title [IMP] image_gallery_option: implement slideshow speed [IMP] image_gallery_option: implement slideshow Mar 20, 2025
@fdardenne fdardenne force-pushed the master-mysterious-egg-dafl-1 branch from b169ae3 to ed95df7 Compare March 20, 2025 10:15
const container = this.getContainer(imageGalleryElement);
const currentInterval = imageGalleryElement.querySelector(".carousel").dataset.bsInterval;
const carouselEl = imageGalleryElement.querySelector(".carousel");
const colorContrast =

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the part with vcss === '002' ?

id: "slideshow_" + new Date().getTime(),
colorContrast,
});
carouselEl.removeEventListener("slide.bs.carousel", this.onCarouselSlid);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slide or slid?

This commit add the possibility to add an image in a slideshow gallery.
It also add the possibility of reordering images in a slideshow.
@fdardenne fdardenne force-pushed the master-mysterious-egg-dafl-1 branch from ed95df7 to c3b0ea8 Compare March 20, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants