-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BuilderInputBase and baseProps #4225
Open
robinlej
wants to merge
3
commits into
master-mysterious-egg
Choose a base branch
from
master-mysterious-egg-role-4
base: master-mysterious-egg
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
c7f4cac
to
8b8403e
Compare
agau-odoo
requested changes
Mar 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments on some points I felt needed discussion, but otherwise good PR
addons/html_builder/static/src/core/building_blocks/builder_input_base.js
Outdated
Show resolved
Hide resolved
addons/html_builder/static/src/core/building_blocks/builder_input_base.js
Outdated
Show resolved
Hide resolved
addons/html_builder/static/src/core/building_blocks/builder_number_input.xml
Outdated
Show resolved
Hide resolved
addons/html_builder/static/src/core/building_blocks/builder_input_base.js
Outdated
Show resolved
Hide resolved
addons/html_builder/static/src/core/building_blocks/builder_input_base.js
Outdated
Show resolved
Hide resolved
addons/html_builder/static/src/core/building_blocks/builder_input_base.js
Outdated
Show resolved
Hide resolved
addons/html_builder/static/src/core/building_blocks/builder_number_input.js
Outdated
Show resolved
Hide resolved
addons/html_builder/static/src/core/building_blocks/builder_number_input.js
Outdated
Show resolved
Hide resolved
8b8403e
to
b29a409
Compare
b29a409
to
efcff5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.