Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] developer: added "--shell-file" CLI option #11334

Closed
wants to merge 1 commit into from

Conversation

lordkrandel
Copy link
Contributor

@lordkrandel lordkrandel commented Nov 6, 2024

Added the description for the new --shell-file option, which overrides the the $PYTHONSTARTUP env variable to initialize the shell session with a startup Python script.

Related docs: https://docs.python.org/3/using/cmdline.html#envvar-PYTHONSTARTUP

Community PR: odoo/odoo#185075
Task link
task-4306704

@robodoo
Copy link
Collaborator

robodoo commented Nov 6, 2024

Pull request status dashboard

Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message should be adapted to the repository in which it will be merged. "base" is not a documentation directory, and the commit is not about adding a shell feature but about documenting it.

@lordkrandel lordkrandel force-pushed the master-shell-setup-file-pgi branch from 70a5fab to 0d04f81 Compare November 14, 2024 14:54
lordkrandel added a commit to odoo-dev/odoo that referenced this pull request Nov 15, 2024
The $PYTHONSTARTUP env variable can contain a python script that is used
by Python shell at the start of any interactive session.

- fix this feature from being broken in python and ptpython
- include a new --shell-file= shell parameter to override the env
  variable $PYTHONSTARTUP
- group the two shell parameters in a new options group
- remove custom python shells' banners from the start of the session
- shell options can now be saved in the configuration file.

Python docs: https://docs.python.org/3/using/cmdline.html#envvar-PYTHONSTARTUP

Documentation PR: odoo/documentation#11334
task-4306704
@lordkrandel lordkrandel changed the title [IMP] base: "--shell-file" option override for $PYTHONSTARTUP [IMP] developer: added "--shell-file" CLI option Nov 20, 2024
@lordkrandel lordkrandel force-pushed the master-shell-setup-file-pgi branch 2 times, most recently from 0ad9f95 to ad07f50 Compare November 20, 2024 13:13
@lordkrandel lordkrandel force-pushed the master-shell-setup-file-pgi branch 2 times, most recently from 9036112 to e4c6445 Compare November 20, 2024 15:38
Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo delegate+

Added the description for the new '--shell-file' option, which overrides
the the $PYTHONSTARTUP env variable to initialize the shell session with
a startup Python script.

Related docs: https://docs.python.org/3/using/cmdline.html#envvar-PYTHONSTARTUP

Community PR: odoo/odoo#185075
task-4306704
lordkrandel added a commit to odoo-dev/odoo that referenced this pull request Nov 27, 2024
The $PYTHONSTARTUP env variable can contain a python script that is used
by Python shell at the start of any interactive session.

- fix this feature from being broken in python and ptpython
- include a new `--shell-file=` shell parameter to override the env
  variable $PYTHONSTARTUP
- group the two shell parameters in a new options group
- remove custom python shells' banners from the start of the session
- shell options can now be saved in the configuration file.

Python docs: https://docs.python.org/3/using/cmdline.html#envvar-PYTHONSTARTUP

Documentation PR: odoo/documentation#11334
task-4306704
@lordkrandel lordkrandel force-pushed the master-shell-setup-file-pgi branch from e4c6445 to 222426d Compare November 27, 2024 09:25
@lordkrandel
Copy link
Contributor Author

@robodoo r+

robodoo pushed a commit to odoo/odoo that referenced this pull request Nov 27, 2024
The $PYTHONSTARTUP env variable can contain a python script that is used
by Python shell at the start of any interactive session.

- fix this feature from being broken in python and ptpython
- include a new `--shell-file=` shell parameter to override the env
  variable $PYTHONSTARTUP
- group the two shell parameters in a new options group
- remove custom python shells' banners from the start of the session
- shell options can now be saved in the configuration file.

Python docs: https://docs.python.org/3/using/cmdline.html#envvar-PYTHONSTARTUP

Documentation PR: odoo/documentation#11334
task-4306704

closes #185075

Signed-off-by: Julien Castiaux (juc) <[email protected]>
robodoo pushed a commit that referenced this pull request Nov 27, 2024
Added the description for the new '--shell-file' option, which overrides
the the $PYTHONSTARTUP env variable to initialize the shell session with
a startup Python script.

Related docs: https://docs.python.org/3/using/cmdline.html#envvar-PYTHONSTARTUP

Community PR: odoo/odoo#185075
task-4306704

closes #11334

Signed-off-by: Paolo Gatti (pgi) <[email protected]>
@robodoo robodoo added the 18.1 label Nov 27, 2024
@robodoo robodoo closed this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants