Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] studio: configure export of customizations #12046

Closed
wants to merge 1 commit into from

Conversation

auva-odoo
Copy link
Contributor

@auva-odoo auva-odoo commented Feb 12, 2025

Task-4207013

@robodoo
Copy link
Collaborator

robodoo commented Feb 12, 2025

Pull request status dashboard

@mcsi-odoo mcsi-odoo force-pushed the 18.0-studio-export-import-master-data-mcsi branch from 120e15f to 78b4c2a Compare February 12, 2025 09:38
@mcsi-odoo mcsi-odoo changed the title 18.0 studio export import master data mcsi [IMP] studio: configure export of customizations Feb 12, 2025
@mcsi-odoo mcsi-odoo marked this pull request as ready for review February 12, 2025 09:41
@C3POdoo C3POdoo requested a review from a team February 12, 2025 09:43
@mcsi-odoo mcsi-odoo requested review from a team and removed request for a team February 12, 2025 10:08
@xpl-odoo xpl-odoo requested review from xpl-odoo and removed request for a team February 21, 2025 15:14
Copy link
Contributor

@xpl-odoo xpl-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mcsi-odoo ! Thanks for the PR, quite an interesting feature I never explored, so it's great to see it documented :)
We can address all my suggestions together next week if you would like, but great job overall :)

@mcsi-odoo mcsi-odoo force-pushed the 18.0-studio-export-import-master-data-mcsi branch 2 times, most recently from 717169c to e583984 Compare February 27, 2025 14:04
@mcsi-odoo mcsi-odoo requested a review from xpl-odoo February 27, 2025 14:31
Copy link
Contributor

@xpl-odoo xpl-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor changes, great job :)

Comment on lines 271 to 272
Choose whether to only :guilabel:`Include Data` or to also
:guilabel:`Include Demo Data`, then click the :guilabel:`Export` button.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could only include demo data. Or no data at all (but then it wouldn't make much sense to be configuring the data to include)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, ticking 'Include Demo Data' also ticks 'Include Data' so there's no way to only 'Include Demo Data'. I'm asking Cédric about a scenario where a user might not include any data (odd as that might seem to us). It's true I didn't consider that option.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text updated to explain the three options (nothing ticked, only Include Data, or Include Data + Include Demo Data)

@mcsi-odoo mcsi-odoo force-pushed the 18.0-studio-export-import-master-data-mcsi branch 2 times, most recently from d756a64 to 4168599 Compare March 7, 2025 08:31
@mcsi-odoo mcsi-odoo requested a review from xpl-odoo March 7, 2025 09:42
Copy link
Contributor Author

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a look on behalf of @xpl-odoo while sick. LGTM!

@robodoo delegate+

@mcsi-odoo mcsi-odoo force-pushed the 18.0-studio-export-import-master-data-mcsi branch from 4168599 to 320de1c Compare March 24, 2025 09:49
@mcsi-odoo
Copy link
Contributor

@robodoo r+

@robodoo
Copy link
Collaborator

robodoo commented Mar 24, 2025

I'm sorry, @mcsi-odoo. I'm afraid I can't do that.

@auva-odoo
Copy link
Contributor Author

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants