Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] developer/localization: adapt link to fiscal position file #12189

Closed
wants to merge 1 commit into from

Conversation

jco-odoo
Copy link
Contributor

No description provided.

@robodoo
Copy link
Collaborator

robodoo commented Feb 26, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team February 26, 2025 15:38
@jco-odoo jco-odoo force-pushed the 18.0-escanaryigic-jco branch from 45dc1c0 to 5b11d77 Compare March 18, 2025 13:28
@jco-odoo
Copy link
Contributor Author

@odoo/account-dev-doc-review Could you check as the link branch is approved and I would like to get it merged to avoid conflicts, ... The only reason we needed this PR is because for a link to the fiscal positions csv, its filename changes. (because of the CoA structure changing, ...)

@william-andre
Copy link
Contributor

@robodoo r+

@robodoo
Copy link
Collaborator

robodoo commented Mar 21, 2025

I'm sorry, @william-andre. I'm afraid I can't do that.

@william-andre william-andre requested a review from a team March 21, 2025 09:42
@Feyensv Feyensv changed the title [IMP] localizationsdev: adapt link to fiscal position file [IMP] developer/localization: adapt link to fiscal position file Mar 21, 2025
Copy link
Collaborator

@Feyensv Feyensv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo r+ squash delegate+

@robodoo
Copy link
Collaborator

robodoo commented Mar 21, 2025

Merge method set to squash.

robodoo pushed a commit to odoo/odoo that referenced this pull request Mar 21, 2025
This commit adds Canary Island CoA from OCA's l10n_es_igic module.

The initial migration was done using the script from:
`https://github.com/william-andre/transform_coa`

Along that, we also applied few more things:

- use the english translations in `name` and moved the spanish names in
  `name@es`
- added auto-apply on canary's fiscal position based on states
- adapt `-100` taxes on some of the taxes in canary
- refactored the template flow

The template dependencies will be like the following:

```
              es_common (withholding taxes + common accounts)
           /            \
  es_canary_common   es_common_mainland
(taxes + canary accounts)   (taxes)
        |                   |
(canary-assoc/full/pymes)  (assec/full/pymes/coop_pymes)
 same accounts used
as in mainland through
csv loading override
```

Thanks to Binhex (specially Christian).

Task-id: 3354514
Part-of: #195864
Related: odoo/documentation#12189
Signed-off-by: Ruben Gomes (rugo) <[email protected]>
robodoo pushed a commit to odoo/odoo that referenced this pull request Mar 21, 2025
We added the modelo 420 to be able to calculate
the basic tax return for Canary Islands.  (but
no BOE yet)

The report is in 2 columns to distinguish base
amount and tax amount and the casilla numbers
are put at the start of each report line.

Thanks to Binhex (specially Christian).

closes #195864

Task-id: 3354514
Related: odoo/documentation#12189
Signed-off-by: Ruben Gomes (rugo) <[email protected]>
robodoo pushed a commit that referenced this pull request Mar 21, 2025
robodoo pushed a commit to odoo/odoo that referenced this pull request Mar 21, 2025
This commit adds Canary Island CoA from OCA's l10n_es_igic module.

The initial migration was done using the script from:
`https://github.com/william-andre/transform_coa`

Along that, we also applied few more things:

- use the english translations in `name` and moved the spanish names in
  `name@es`
- added auto-apply on canary's fiscal position based on states
- adapt `-100` taxes on some of the taxes in canary
- refactored the template flow

The template dependencies will be like the following:

```
              es_common (withholding taxes + common accounts)
           /            \
  es_canary_common   es_common_mainland
(taxes + canary accounts)   (taxes)
        |                   |
(canary-assoc/full/pymes)  (assec/full/pymes/coop_pymes)
 same accounts used
as in mainland through
csv loading override
```

Thanks to Binhex (specially Christian).

Task-id: 3354514
Part-of: #195864
Related: odoo/documentation#12189
Signed-off-by: Ruben Gomes (rugo) <[email protected]>
robodoo pushed a commit to odoo/odoo that referenced this pull request Mar 21, 2025
We added the modelo 420 to be able to calculate
the basic tax return for Canary Islands.  (but
no BOE yet)

The report is in 2 columns to distinguish base
amount and tax amount and the casilla numbers
are put at the start of each report line.

Thanks to Binhex (specially Christian).

closes #195864

Task-id: 3354514
Related: odoo/documentation#12189
Signed-off-by: Ruben Gomes (rugo) <[email protected]>
@robodoo robodoo closed this in 31a173d Mar 21, 2025
robodoo pushed a commit that referenced this pull request Mar 22, 2025
closes #12586

Forward-port-of: #12189
Related: odoo/odoo#202928
Signed-off-by: Victor Feyens (vfe) <[email protected]>
Signed-off-by: Josse Colpaert (jco) <[email protected]>
robodoo pushed a commit that referenced this pull request Mar 22, 2025
closes #12586

Forward-port-of: #12189
Related: odoo/odoo#202928
Signed-off-by: Victor Feyens (vfe) <[email protected]>
Signed-off-by: Josse Colpaert (jco) <[email protected]>
mwath pushed a commit to odoo-dev/odoo that referenced this pull request Mar 25, 2025
This commit adds Canary Island CoA from OCA's l10n_es_igic module.

The initial migration was done using the script from:
`https://github.com/william-andre/transform_coa`

Along that, we also applied few more things:

- use the english translations in `name` and moved the spanish names in
  `name@es`
- added auto-apply on canary's fiscal position based on states
- adapt `-100` taxes on some of the taxes in canary
- refactored the template flow

The template dependencies will be like the following:

```
              es_common (withholding taxes + common accounts)
           /            \
  es_canary_common   es_common_mainland
(taxes + canary accounts)   (taxes)
        |                   |
(canary-assoc/full/pymes)  (assec/full/pymes/coop_pymes)
 same accounts used
as in mainland through
csv loading override
```

Thanks to Binhex (specially Christian).

Task-id: 3354514
Part-of: odoo#195864
Related: odoo/documentation#12189
Signed-off-by: Ruben Gomes (rugo) <[email protected]>
mwath pushed a commit to odoo-dev/odoo that referenced this pull request Mar 25, 2025
We added the modelo 420 to be able to calculate
the basic tax return for Canary Islands.  (but
no BOE yet)

The report is in 2 columns to distinguish base
amount and tax amount and the casilla numbers
are put at the start of each report line.

Thanks to Binhex (specially Christian).

closes odoo#195864

Task-id: 3354514
Related: odoo/documentation#12189
Signed-off-by: Ruben Gomes (rugo) <[email protected]>
omar-sherif9992 pushed a commit to odoo-dev/odoo that referenced this pull request Mar 26, 2025
This commit adds Canary Island CoA from OCA's l10n_es_igic module.

The initial migration was done using the script from:
`https://github.com/william-andre/transform_coa`

Along that, we also applied few more things:

- use the english translations in `name` and moved the spanish names in
  `name@es`
- added auto-apply on canary's fiscal position based on states
- adapt `-100` taxes on some of the taxes in canary
- refactored the template flow

The template dependencies will be like the following:

```
              es_common (withholding taxes + common accounts)
           /            \
  es_canary_common   es_common_mainland
(taxes + canary accounts)   (taxes)
        |                   |
(canary-assoc/full/pymes)  (assec/full/pymes/coop_pymes)
 same accounts used
as in mainland through
csv loading override
```

Thanks to Binhex (specially Christian).

Task-id: 3354514
Part-of: odoo#195864
Related: odoo/documentation#12189
Signed-off-by: Ruben Gomes (rugo) <[email protected]>
omar-sherif9992 pushed a commit to odoo-dev/odoo that referenced this pull request Mar 26, 2025
We added the modelo 420 to be able to calculate
the basic tax return for Canary Islands.  (but
no BOE yet)

The report is in 2 columns to distinguish base
amount and tax amount and the casilla numbers
are put at the start of each report line.

Thanks to Binhex (specially Christian).

closes odoo#195864

Task-id: 3354514
Related: odoo/documentation#12189
Signed-off-by: Ruben Gomes (rugo) <[email protected]>
gamarino pushed a commit to numaes/numa-public-odoo that referenced this pull request Mar 27, 2025
This commit adds Canary Island CoA from OCA's l10n_es_igic module.

The initial migration was done using the script from:
`https://github.com/william-andre/transform_coa`

Along that, we also applied few more things:

- use the english translations in `name` and moved the spanish names in
  `name@es`
- added auto-apply on canary's fiscal position based on states
- adapt `-100` taxes on some of the taxes in canary
- refactored the template flow

The template dependencies will be like the following:

```
              es_common (withholding taxes + common accounts)
           /            \
  es_canary_common   es_common_mainland
(taxes + canary accounts)   (taxes)
        |                   |
(canary-assoc/full/pymes)  (assec/full/pymes/coop_pymes)
 same accounts used
as in mainland through
csv loading override
```

Thanks to Binhex (specially Christian).

Task-id: 3354514
Part-of: odoo/odoo#195864
Related: odoo/documentation#12189
Signed-off-by: Ruben Gomes (rugo) <[email protected]>
gamarino pushed a commit to numaes/numa-public-odoo that referenced this pull request Mar 27, 2025
We added the modelo 420 to be able to calculate
the basic tax return for Canary Islands.  (but
no BOE yet)

The report is in 2 columns to distinguish base
amount and tax amount and the casilla numbers
are put at the start of each report line.

Thanks to Binhex (specially Christian).

closes odoo/odoo#195864

Task-id: 3354514
Related: odoo/documentation#12189
Signed-off-by: Ruben Gomes (rugo) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants