[IMP] General: Search bar tweaks #12351
Conversation
|
|
|
@dikd-odoo ready for a review! |
There was a problem hiding this comment.
Hi @justinmallette wonderful job on this PR! I added a few suggested edits throughout the doc, but am approving as the flows worked perfectly and readablity looked great. Regarding the definite article when using icons (saying "click the drop-down menu" vs "click drop-down", I wasn't sure if this was a concrete style guide rule, but it's something that I often see in documentation and tutorials and what I use in my own. Will defer to your preference and the final reviewer on that. Thank you!
justinmallette
force-pushed
the
18.0-general-search-bar-tweaks-juma
branch
from
babef76 to
73aa582
Compare
|
@Felicious this is ready for review (also do you know why the tests aren't running on it?) |
There was a problem hiding this comment.
LGTM @justinmallette ! (:
Just a small tweak needed—the icons need a slight adjustment to align with the team's standards (flagged by the Vale linter). Once that's sorted, this PR is good to go for the next stage! 🚀
P.S.: reminder to add a Github PR description! Something brief like "replace emojis with icons" is enough (:
| <search/filters>`, :ref:`Group By <search/group>`, and :ref:`Favorites <search/favorites>` drop-down | ||
| menus. | ||
| relevant records. The search bar is located at the top of the view: start typing to :ref:`search for | ||
| values <search/values>`, or click the :icon:`fa-caret-down` (**dropdown**) icon to access the |
There was a problem hiding this comment.
guilabel for the icon descriptor! (:
|
|
||
| .. example:: | ||
| Instead of adding a :ref:`custom filter <search/custom-filters>` to select records where | ||
| *Mitchell Admin* is the salesperson on the *Sales Analysis* report (:menuselection:`Sales app --> | ||
| Reporting --> Sales`), search for `Mitch`, and click the :guilabel:`⏵ (right arrow)` next to | ||
| :guilabel:`Search Salesperson for: Mitch`, and select :guilabel:`Mitchell Admin`. | ||
| Reporting --> Sales`), search for `Mitch`, and click the :icon:`fa-caret-right` (**submenu**) |
There was a problem hiding this comment.
flagging another icon descriptor (: I'll trust you to find the rest!
| :doc:`Purchase <../inventory_and_mrp/purchase/advanced/analyze>` report for the *Purchase* app, | ||
| their search bars. This includes the :doc:`Overall Equipment Effectiveness | ||
| <../inventory_and_mrp/manufacturing/reporting/oee>` report for the **Manufacturing** app and the | ||
| :doc:`Purchase <../inventory_and_mrp/purchase/advanced/analyze>` report for the **Purchase** app, |
There was a problem hiding this comment.
| :doc:`Purchase <../inventory_and_mrp/purchase/advanced/analyze>` report for the **Purchase** app, | |
| :doc:`Purchase Analysis <../inventory_and_mrp/purchase/advanced/analyze>` report for the **Purchase** app, |
justinmallette
force-pushed
the
18.0-general-search-bar-tweaks-juma
branch
from
73aa582 to
7c03f11
Compare
Co-authored-by: Dina Klarisse Dugar <[email protected]>
justinmallette
force-pushed
the
18.0-general-search-bar-tweaks-juma
branch
from
7c03f11 to
6748ec0
Compare
|
@samueljlieber ready for TR! |
There was a problem hiding this comment.
Looks good to me @justinmallette 👍
Thank you!
..
@robodoo r+
replace emojis with icons