Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] l10n_in_ewaybill_stock: add documentation for Ewaybill on stock #12353

Closed
wants to merge 1 commit into from

Conversation

hamo-odoo
Copy link
Contributor

task-4574445

@hamo-odoo hamo-odoo requested a review from jva-odoo March 11, 2025 06:18
@robodoo
Copy link
Collaborator

robodoo commented Mar 11, 2025

Pull request status dashboard

@hamo-odoo hamo-odoo marked this pull request as ready for review March 17, 2025 13:25
@C3POdoo C3POdoo requested a review from a team March 17, 2025 13:31
@afma-odoo afma-odoo requested review from afma-odoo and removed request for a team March 17, 2025 13:58
Copy link
Contributor

@afma-odoo afma-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hamo-odoo!Thank you for your work on this Indian localization page :)
I added some comments/suggestions. Please take a look at it and let me know if you have any questions.
Thanks!

@hamo-odoo hamo-odoo force-pushed the 17.0-ewaybill-stock-doc-hamo branch 2 times, most recently from aa0b47c to 7a7ca76 Compare March 18, 2025 05:34
@hamo-odoo
Copy link
Contributor Author

@afma-odoo Thank you for suggestion and making it look more clean and nice. I have made the suggested changes

@hamo-odoo hamo-odoo requested a review from afma-odoo March 18, 2025 05:36
@hamo-odoo hamo-odoo force-pushed the 17.0-ewaybill-stock-doc-hamo branch 2 times, most recently from 3a74750 to 19eb6a7 Compare March 18, 2025 07:15
Copy link
Contributor

@afma-odoo afma-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hamo-odoo! Thanks for the changes ;)
I just have some comments and suggestions. For lines 307-309, I'm not sure which fields to fill and what information to include in those fields. Can you specify it?
Thank you!

@hamo-odoo hamo-odoo force-pushed the 17.0-ewaybill-stock-doc-hamo branch 2 times, most recently from d65cc95 to d739afb Compare March 18, 2025 09:38
@hamo-odoo
Copy link
Contributor Author

@afma-odoo Changes done

Copy link
Contributor

@afma-odoo afma-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hamo-odoo for updating the page!
I add the be-doc-review for the next step ;)

@afma-odoo afma-odoo requested a review from a team March 18, 2025 09:59
@hamo-odoo hamo-odoo changed the title [IMP] l10n_in_ewabill_stock: add documention for Ewaybill on stock [IMP] l10n_in_ewaybill_stock: add documention for Ewaybill on stock Mar 18, 2025
@hamo-odoo hamo-odoo force-pushed the 17.0-ewaybill-stock-doc-hamo branch 2 times, most recently from a5055e3 to eb0574d Compare March 18, 2025 12:10
@hamo-odoo hamo-odoo changed the title [IMP] l10n_in_ewaybill_stock: add documention for Ewaybill on stock [IMP] l10n_in_ewaybill_stock: add documentation for Ewaybill on stock Mar 18, 2025
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @hamo-odoo thank you for your work! I added a few comments and suggestions 🙂

@hamo-odoo hamo-odoo force-pushed the 17.0-ewaybill-stock-doc-hamo branch from eb0574d to d314abc Compare March 21, 2025 12:22
@hamo-odoo hamo-odoo requested a review from auva-odoo March 21, 2025 12:23
@hamo-odoo hamo-odoo force-pushed the 17.0-ewaybill-stock-doc-hamo branch 3 times, most recently from 3f0af97 to c13db9f Compare March 21, 2025 12:37
@hamo-odoo
Copy link
Contributor Author

@auva-odoo Can you please checkout the changes?

@hamo-odoo hamo-odoo force-pushed the 17.0-ewaybill-stock-doc-hamo branch from c13db9f to dbaf0b3 Compare March 21, 2025 12:41
@auva-odoo auva-odoo force-pushed the 17.0-ewaybill-stock-doc-hamo branch from dbaf0b3 to f9b0c10 Compare March 21, 2025 13:10
Copy link
Contributor Author

@hamo-odoo hamo-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@auva-odoo LGTM!
Thanks for helping me out

Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hamo-odoo As discussed, I pushed some changes 🙂 Could you review them to ensure everything looks good and remains accurate? You can r+ yourself if it does (and when all checks have passed 😉 )

@robodoo delegate+

Copy link
Contributor Author

@hamo-odoo hamo-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants