-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] l10n_in_ewaybill_stock: add documentation for Ewaybill on stock #12353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hamo-odoo!Thank you for your work on this Indian localization page :)
I added some comments/suggestions. Please take a look at it and let me know if you have any questions.
Thanks!
aa0b47c
to
7a7ca76
Compare
@afma-odoo Thank you for suggestion and making it look more clean and nice. I have made the suggested changes |
3a74750
to
19eb6a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hamo-odoo! Thanks for the changes ;)
I just have some comments and suggestions. For lines 307-309, I'm not sure which fields to fill and what information to include in those fields. Can you specify it?
Thank you!
d65cc95
to
d739afb
Compare
@afma-odoo Changes done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @hamo-odoo for updating the page!
I add the be-doc-review for the next step ;)
a5055e3
to
eb0574d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @hamo-odoo thank you for your work! I added a few comments and suggestions 🙂
content/applications/finance/fiscal_localizations/india/e-waybill-stock-report.png
Outdated
Show resolved
Hide resolved
eb0574d
to
d314abc
Compare
3f0af97
to
c13db9f
Compare
@auva-odoo Can you please checkout the changes? |
c13db9f
to
dbaf0b3
Compare
dbaf0b3
to
f9b0c10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@auva-odoo LGTM!
Thanks for helping me out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hamo-odoo As discussed, I pushed some changes 🙂 Could you review them to ensure everything looks good and remains accurate? You can r+ yourself if it does (and when all checks have passed 😉 )
@robodoo delegate+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
robodoo r+
task-4574445 closes #12353 Signed-off-by: Harsh Modi (hamo) <[email protected]>
task-4574445