Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] project: profitability dashboard #12429

Closed
wants to merge 1 commit into from

Conversation

zulu-odoo
Copy link
Contributor

taskid-4489259

@robodoo
Copy link
Collaborator

robodoo commented Mar 14, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team March 14, 2025 10:24
@zulu-odoo zulu-odoo force-pushed the 18.0-project-profitability-zulu branch from cfc03b1 to 90c2c44 Compare March 14, 2025 10:27
@zulu-odoo zulu-odoo requested review from a team and removed request for a team March 14, 2025 11:49
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear @zulu-odoo I feel like this review is mostly a giant nitpick so I want to apologize for that. That said, I do want to say that I think the information is overall very clear and complete (which is probably why I only have very minor and annoying comments 🙈)

Just one general comment: since Project profitability dashboard is the only h2 heading in here, I would consider removing it. I think the text in that section flows well with the intro. If you want to break up the text a bit (because it will be a big block of text, kinda), I would consider adding a screenshot (!) somewhere after you itnroduce the profitability dashboard (maybe after you explain how to access it?) showing a nice-looking profitability dashboard. What do you think?

Thank you!!

@zulu-odoo zulu-odoo force-pushed the 18.0-project-profitability-zulu branch 2 times, most recently from 54a20a9 to a3fcc82 Compare March 20, 2025 15:09
@zulu-odoo zulu-odoo requested a review from auva-odoo March 21, 2025 07:53
@zulu-odoo
Copy link
Contributor Author

Dear @auva-odoo,
I made the changes. Please check them whenever you have the time! If all is good, feel free to push approve hard DOT, but if not, I'll check it again next week, there's no rush with publishing this one. Thank you so much! <3

@zulu-odoo zulu-odoo force-pushed the 18.0-project-profitability-zulu branch from a3fcc82 to 7414865 Compare March 21, 2025 08:29
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @zulu-odoo! 🙂

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants