Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] *: correct create examples #12527

Closed
wants to merge 1 commit into from

Conversation

kmagusiak
Copy link
Contributor

Fix some examples to match the method definition of Model.create().

odoo/odoo#202106

@robodoo
Copy link
Collaborator

robodoo commented Mar 17, 2025

Pull request status dashboard

@Feyensv Feyensv changed the title [REF] test_lint: check overwrites of create() [IMP] *: correct create examples Mar 17, 2025
@AntoineVDV
Copy link
Collaborator

@robodoo squash

@robodoo
Copy link
Collaborator

robodoo commented Mar 17, 2025

Merge method set to squash.

Fix some examples to match the method definition of Model.create().
@kmagusiak kmagusiak force-pushed the master-lint-override-create-krma branch from e5b0e13 to a24a0fb Compare March 17, 2025 15:15
@Feyensv
Copy link
Collaborator

Feyensv commented Mar 20, 2025

@robodoo delegate+

@Feyensv Feyensv removed request for a team March 20, 2025 13:29
@kmagusiak
Copy link
Contributor Author

@robodoo r+

robodoo pushed a commit to odoo/odoo that referenced this pull request Mar 20, 2025
Move the methods to sanitize into the test and add modules to ignore so
that we can further remove the ignored methods.
Add a note to sanitize all methods in the future.

Part-of: #202106
Related: odoo/enterprise#81599
Related: odoo/documentation#12527
Signed-off-by: Raphael Collet <[email protected]>
robodoo pushed a commit to odoo/odoo that referenced this pull request Mar 20, 2025
One exception exists in `ir.config_paramter`, ignore it for now so that
the test runs for other models.

Part-of: #202106
Related: odoo/enterprise#81599
Related: odoo/documentation#12527
Signed-off-by: Raphael Collet <[email protected]>
robodoo pushed a commit to odoo/odoo that referenced this pull request Mar 20, 2025
Check that the create method is properly overridden.

Forgetting to add `@api.model_create_multi` makes most methods unusable
over RPC.

closes #202106

Related: odoo/enterprise#81599
Related: odoo/documentation#12527
Signed-off-by: Raphael Collet <[email protected]>
robodoo pushed a commit that referenced this pull request Mar 20, 2025
Fix some examples to match the method definition of Model.create().

closes #12527

Related: odoo/odoo#202106
Related: odoo/enterprise#81599
Signed-off-by: Krzysztof Magusiak (krma) <[email protected]>
@robodoo robodoo added the 18.3 label Mar 20, 2025
@robodoo robodoo closed this Mar 20, 2025
@kmagusiak kmagusiak deleted the master-lint-override-create-krma branch March 20, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants