IMP] developer/reference/cli: add --pre-upgrade-scripts, improve --upgrade-path #12528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
aj-fuentes
force-pushed
the
16.0-imp_force_script2-afu
branch
from
62215d3 to
b7c4e5a
Compare
KangOl
reviewed
Mar 17, 2025
content/developer/reference/cli.rst
Outdated
| @@ -94,6 +94,12 @@ Running the server | |||
|
|
|||
| specify an additional upgrade path. | |||
|
|
|||
| .. option:: --pre-upgrade-scripts <pre_upgrade_scripts> | |||
|
|
|||
| specify upgrade scripts to be run before loading base module when an upgrade | |||
There was a problem hiding this comment.
Suggested change
| specify upgrade scripts to be run before loading base module when an upgrade | |
| comma-separated list of path to upgrade scripts to be run before loading base module when an upgrade |
There was a problem hiding this comment.
I pushed an extra commit to improve the docs of --upgrade-path that was very thin... to say the least :D
aj-fuentes
force-pushed
the
16.0-imp_force_script2-afu
branch
2 times, most recently
from
0fcb216 to
2d4d8ab
Compare
|
@aj-fuentes Just don't forget to adapt your commits because they don't make sense in this context and repo ;) |
|
Hi @AntoineVDV, I don't know what makes sense here :) Would you give a suggestion please? |
|
@aj-fuentes Same logic as in other repos, I'd say, so something like: "[IMP] developer/cli: document It makes it easier to figure out what we're looking at when navigating the commit history of the developer doc, otherwise it'd just be a bunch of "[IMP] core" commits, since all odoo/odoo framework commits look alike. |
Document the new cli option.
Be explicit about what we expect as parameter.
aj-fuentes
force-pushed
the
16.0-imp_force_script2-afu
branch
from
2d4d8ab to
97fadd8
Compare
|
OK, done. |
aj-fuentes
changed the title
|
@robodoo r+ |
|
@aj-fuentes because this PR has multiple commits, I need to know how to merge it:
|
|
@robodoo rebase-ff |
|
Merge method set to rebase and fast-forward. |
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Mar 19, 2025
Upgrade scripts are run only when there is an update of the module version. This is not flexible enough. After a major upgrade developers need to upgrade their custom modules. Unfortunately the tools in `upgrade-util` repo that modify modules (`merge_module`, `rename_module`, ...) should be done before loading base module. The latter is already upgraded after a major upgrade thus no upgrade scripts are run for it. In this patch we add a mechanism to run specific upgrade scripts before loading base. closes #202014 Related: odoo/documentation#12528 Signed-off-by: Christophe Simonis (chs) <[email protected]> Co-authored-by: Christophe Simonis <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Mar 19, 2025
Document the new cli option. Part-of: #12528 Related: odoo/odoo#202014 Signed-off-by: Alvaro Fuentes Suarez (afu) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Mar 19, 2025
Be explicit about what we expect as parameter. closes #12528 Related: odoo/odoo#202014 Signed-off-by: Alvaro Fuentes Suarez (afu) <[email protected]>
This was referenced Mar 19, 2025
Nokoz
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Mar 25, 2025
Upgrade scripts are run only when there is an update of the module version. This is not flexible enough. After a major upgrade developers need to upgrade their custom modules. Unfortunately the tools in `upgrade-util` repo that modify modules (`merge_module`, `rename_module`, ...) should be done before loading base module. The latter is already upgraded after a major upgrade thus no upgrade scripts are run for it. In this patch we add a mechanism to run specific upgrade scripts before loading base. closes odoo#202014 Related: odoo/documentation#12528 Signed-off-by: Christophe Simonis (chs) <[email protected]> Co-authored-by: Christophe Simonis <[email protected]>
odoo-pda
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Mar 28, 2025
Upgrade scripts are run only when there is an update of the module version. This is not flexible enough. After a major upgrade developers need to upgrade their custom modules. Unfortunately the tools in `upgrade-util` repo that modify modules (`merge_module`, `rename_module`, ...) should be done before loading base module. The latter is already upgraded after a major upgrade thus no upgrade scripts are run for it. In this patch we add a mechanism to run specific upgrade scripts before loading base. closes odoo#202014 Related: odoo/documentation#12528 Signed-off-by: Christophe Simonis (chs) <[email protected]> Co-authored-by: Christophe Simonis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[IMP] developer/reference/cli: --pre-upgrade-scripts
Document the new cli option.
[IMP] developer/reference/cli: improve docs of --upgrade-path
Be explicit about what we expect as parameter.