[FIX] payment_providers: reword and add missing Nuvei methods #12576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
samueljlieber
approved these changes
Mar 20, 2025
There was a problem hiding this comment.
Hi @andg-odoo, thanks for this PR! I'm just giving feedback as requested from @masi-odoo :)
These changes look good to me!
cc. @odoo/payment-doc-review
|
Thanks @andg-odoo for the PR and for the quick review @samueljlieber ! @odoo/payment-doc-review let us know if there is anything else on our side. Since this is a launch being done in coordination with the Nuvei team it will be the best that we can merge as soon as possible. Thanks for the support! |
auva-odoo
reviewed
Mar 21, 2025
| | - Card (AMEX, Mastercard, Visa) | - Banco Guayaquil | | ||
| | | - Banco Pichincha | | ||
| | - Card (AMEX, Mastercard, Visa) | - AstroPay TEF (Banco Guayaquil, | | ||
| | | Banco Pichincha) | |
There was a problem hiding this comment.
I also see Facilito under Astropay TEF, should we mention it as well?
There was a problem hiding this comment.
Not sure how I missed that, added Facilito as well, thank you @auva-odoo !
The Oxxo Pay payment method was accidentally left out of the documentation on merge. This PR properly adds it under Mexico. In addition, feedback-wise it's hard to find the payment methods that are hidden under others like AstroPay TEF (Banco Guayaquil, Banco Pichincha) and Local Payments (Abitab, RedPagos) since it doesn't directly appear in the list of payment methods. This change makes it apparent what you need to enable to be able to use these methods.
andg-odoo
force-pushed
the
18.0-add-missing-nuvei-methods-andg
branch
from
04c7c1e to
17d3e34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Oxxo Pay payment method was accidentally left out of the documentation on merge. This PR properly adds it under Mexico.
In addition, feedback-wise it's hard to find the payment methods that are hidden under others like AstroPay TEF (Banco Guayaquil, Banco Pichincha) and Local Payments (Abitab, RedPagos) since it doesn't directly appear in the list of payment methods. This change makes it apparent what you need to enable to be able to use these methods.