vaev-layout: Refact builder reflecting block/inline outside-display b… #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauloamed
force-pushed
the
palm-build-inline-box
branch
3 times, most recently
from
d567ffe to
1f7b6e1
Compare
pauloamed
commented
Mar 20, 2025
| @@ -45,6 +45,10 @@ struct PdfPrinter : public FilePrinter { | |||
| for (auto& [_, value] : fontManager.mapping._els) { | |||
| auto& [id, fontFace] = value; | |||
|
|
|||
| if (not fontFace.is<Text::TtfFontface>()) { | |||
There was a problem hiding this comment.
fallback font or panic?
pauloamed
commented
Mar 20, 2025
pauloamed
commented
Mar 20, 2025
pauloamed
commented
Mar 20, 2025
pauloamed
commented
Mar 20, 2025
|
|
||
| stack.add(makeRc<Scene::Text>(frag.metrics.borderBox().topStart().cast<f64>(), *prose)); | ||
| if (auto ic = frag.box->content.is<InlineBox>()) { | ||
| stack.add(makeRc<Scene::Text>(frag.metrics.contentBox().topStart().cast<f64>(), ic->prose)); |
There was a problem hiding this comment.
Check with clem about borderbox->contentbox
pauloamed
commented
Mar 20, 2025
pauloamed
commented
Mar 20, 2025
pauloamed
force-pushed
the
palm-build-inline-box
branch
4 times, most recently
from
2569971 to
00bf848
Compare
…ehaviour and better inline handling.
…nt-baseline properties.
pauloamed
force-pushed
the
palm-build-inline-box
branch
from
00bf848 to
8e6fb50
Compare
|
ill reopen this once its actually finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ehaviour and better inline handling.