Chapter 15: The final word

Author: ThomasSchneider-94

estate/__manifest__.py

@@ -7,7 +7,7 @@
         'base'
     ],
     'data': [
-        'ir.model.access.csv',
+        'security/ir.model.access.csv',
         'views/estate_property_type_views.xml',
         'views/estate_property_tag_views.xml',
         'views/estate_property_offer_views.xml',

estate/models/__init__.py

@@ -2,4 +2,4 @@
 from . import estate_property_tag
 from . import estate_property_offer
 from . import estate_property
-from . import estate_user
+from . import res_user

estate/models/estate_property.py

@@ -1,9 +1,11 @@
-from odoo import api, fields, models, exceptions
+"""Odoo modules"""
 from dateutil.relativedelta import relativedelta
+from odoo import api, fields, models, exceptions
 from odoo.exceptions import ValidationError
 from odoo.tools import float_utils as fu
 
 class EstateProperty(models.Model):
+    '''Estate property'''
     _name = "estate.property"
     _description = "Property of an estate"
     _order = "sequence, id desc"
@@ -28,7 +30,7 @@ class EstateProperty(models.Model):
     garden_orientation = fields.Selection(
         string = "Orientation",
         selection = [('north', 'North'), ('east', 'East'), ('south', 'South'), ('west', 'West')]
-    )    
+    )
     active = fields.Boolean("Active", default = True)
     state = fields.Selection(
         string = "Status",
@@ -54,9 +56,6 @@ class EstateProperty(models.Model):
 
 
 
-    def _default_date_availability(self):
-        return fields.Date.context_today(self) + relativedelta(months=3)
-
     @api.depends("living_area", "garden_area")
     def _compute_area(self):
         for record in self:
@@ -66,48 +65,50 @@ def _compute_area(self):
     @api.depends("offer_ids")
     def _compute_best_price(self):
         for record in self:
-            if (len(record.offer_ids) > 0):
+            if record.offer_ids:
                 record.best_price = max(record.offer_ids.mapped('price'))
             else:
                 record.best_price = 0
-    
+
     @api.onchange("garden")
     def _onchange_garden(self):
         self.garden_area = 10 if self.garden else 0
         self.garden_orientation = 'north' if self.garden else ''
 
+    def _default_date_availability(self):
+        return fields.Date.context_today(self) + relativedelta(months=3)
+
 
 
     def cancel_property(self):
+        '''Cancel a property selling'''
         for record in self:
-            if (record.state == 'sold'):
+            if record.state == 'sold':
                 raise exceptions.UserError("Sold property cannot be cancelled")
-                continue
-            else:
-                record.state = 'cancelled'
+
+            record.state = 'cancelled'
 
         return True
-    
+
     def sell_property(self):
+        '''Mark an estate property as sold'''
         for record in self:
-            if (record.state == 'cancelled'):
+            if record.state == 'cancelled':
                 raise exceptions.UserError("Cancelled property cannot be sold")
-                continue
-            
+
             record.state = 'sold'
 
         return True
-    
+
     @api.constrains('selling_price', 'expected_price')
     def _expected_price(self):
         for record in self:
-            if (fu.float_is_zero(record.selling_price, precision_rounding = 0.01)): continue
-
-            if (self.selling_price < 0.9 * record.expected_price):
-                raise ValidationError("The selling price cannot be less than 90% of the expected price")
+            if not fu.float_is_zero(record.selling_price, precision_rounding = 0.01):
+                if self.selling_price < 0.9 * record.expected_price:
+                    raise ValidationError("The selling price cannot be less than 90% of the expected price")
 
     @api.ondelete(at_uninstall=False)
     def _prevent_detete(self):
         for record in self:
-            if (record.state != 'new' and record.state != 'cancelled'):
-                raise ValidationError("You cannot delete a record that is not new or cancelled")
+            if record.state not in {'new', 'cancelled'}:
+                raise ValidationError("You cannot delete a record that is not new or cancelled")

estate/models/estate_property_tag.py

@@ -1,6 +1,8 @@
+"""Odoo modules"""
 from odoo import fields, models
 
 class EstatePropertyTag(models.Model):
+    '''Estate property tag'''
     _name = "estate.property.tag"
     _description = "Tag of a property"
     _order = "name"
@@ -9,4 +11,3 @@ class EstatePropertyTag(models.Model):
     color = fields.Integer("Color")
 
     _sql_constraints = [('unique_tag', 'unique(name)', 'The tag already exist !')]
-    

estate/models/estate_property_type.py

@@ -1,6 +1,8 @@
+"""Odoo modules"""
 from odoo import fields, models, api
 
 class EstatePropertyType(models.Model):
+    '''Estate property type'''
     _name = "estate.property.type"
     _description = "Type of a property"
     _order = "name"
@@ -17,5 +19,3 @@ class EstatePropertyType(models.Model):
     def _compute_offer_count(self):
         for record in self:
             record.offer_count = len(record.offer_ids)
-
-

estate/models/estate_user.py estate/models/res_user.py

@@ -1,6 +1,8 @@
-from odoo import fields, models, api
+"""Odoo modules"""
+from odoo import fields, models
 
 class EstateUser(models.Model):
+    '''Salesperson for estate'''
     _inherit = "res.users"
 
     property_ids = fields.One2many("estate.property", "salesperson_id", string = "Properties")

estate/ir.model.access.csv estate/security/ir.model.access.csv

@@ -1,7 +1,7 @@
 <?xml version="1.0"?>
 <odoo>
     <menuitem id="estate_menu_root" name="Real Estate">
-        <menuitem id="estate_advertisements_menu" name="Advertisements">
+        <menuitem id="estate_properties_menu" name="Properties">
             <menuitem id="estate_property_menu_action" action="estate_property_action"/>
         </menuitem>
         <menuitem id="estate_settings_menu" name="Settings">

estate/views/estate_menus.xml

@@ -1,21 +1,21 @@
 <?xml version="1.0"?>
 <odoo>
     <data>
-    <record id="inherited_model_view_form" model="ir.ui.view">
-        <field name="name">res.users.view.form.inherit.estate</field>
-        <field name="model">res.users</field>
-        <field name="inherit_id" ref="base.view_users_simple_form"/>
-        <field name="arch" type="xml">
-            <xpath expr="//form//sheet//group[@name='phone_numbers']" position="after">
-              <notebook>
-                    <page string="Properties">
-                        <group>
-                            <field name="property_ids"/>
-                        </group>
-                    </page>
-                </notebook>
-            </xpath>
-        </field>
-    </record>
+        <record id="res_user_view_form" model="ir.ui.view">
+            <field name="name">res.users.view.form.inherit.estate</field>
+            <field name="model">res.users</field>
+            <field name="inherit_id" ref="base.view_users_simple_form"/>
+            <field name="arch" type="xml">
+                <xpath expr="//form//sheet//group[@name='phone_numbers']" position="after">
+                  <notebook>
+                        <page string="Properties">
+                            <group>
+                                <field name="property_ids"/>
+                            </group>
+                        </page>
+                    </notebook>
+                </xpath>
+            </field>
+        </record>
     </data>
 </odoo>

estate/views/estate_user_views.xml

@@ -9,6 +9,6 @@
         'account'
     ],
     'data': [
-        'ir.model.access.csv'
+        'security/ir.model.access.csv'
     ]
 }

estate_account/__manifest__.py

@@ -1,9 +1,11 @@
 from odoo import fields, models, Command
 
 class EstateProperty(models.Model):
+    '''Estate property'''
     _inherit = "estate.property"
 
     def sell_property(self):
+        '''Mark an estate property as sold and create an invoice'''
         res = super().sell_property()
 
         for record in self:
@@ -31,4 +33,4 @@ def sell_property(self):
                 }
             )
 
-        return res
+        return res