[FIX] util/helpers: return on empty path

[aj-fuentes]

Avoid issues if the caller pass a None object.

[robodoo]

[KangOl]

upgradeci retry with always only hr

[KangOl]

@robodoo r+ p=1

[robodoo]

@KangOl unknown command 'p'.

For your own safety I've ignored everything in your entire comment.

Currently available commands:

command
help	displays this help
r(eview)+	approves the PR, if it's a forwardport also approves all non-detached parents
r(eview)=<number>	only approves the specified parents
fw=no	does not forward-port this PR
fw=default	forward-ports this PR normally
fw=skipci	does not wait for a forward-port's statuses to succeed before creating the next one
up to <branch>	only ports this PR forward to the specified branch (included)
merge	integrate the PR with a simple merge commit, using the PR description as message
rebase-merge	rebases the PR on top of the target branch the integrates with a merge commit, using the PR description as message
rebase-ff	rebases the PR on top of the target branch, then fast-forwards
squash	squashes the PR as a single commit on the target branch, using the PR description as message
delegate+	grants approval rights to the PR author
delegate=<...>	grants approval rights on this PR to the specified github users
default	stages the PR normally
priority	tries to stage this PR first, then adds default PRs if the staging has room
alone	stages this PR only with other PRs of the same priority
cancel=staging	automatically cancels the current staging when this PR becomes ready
check	fetches or refreshes PR metadata, resets mergebot state

Note: this help text is dynamic and will change with the state of the PR.

[KangOl]

@robodoo r+ priority

[KangOl]

@robodoo r+ priority cancel=staging

[robodoo]

This PR is already reviewed, reviewing it again is useless.

[desdelinux]

@aj-fuentes @KangOl

These changes have apparently caused migration issues.

We had a production release that is now failing due to this, this needs to be resolved quickly please.

Ticket Odoo: https://www.odoo.com/es_ES/my/tasks/4033742

Traceback:

2024-07-05 21:29:21,347 25 ERROR db_1790778 odoo.sql_db: bad query:
SELECT id,
res_model,
STRING_TO_ARRAY(field_name, '/')
FROM base_import_mapping
WHERE field_name ~ '\ypassword_crypt\y'
ERROR: relation "base_import_mapping" does not exist
LINE 5: FROM base_import_mapping
^

2024-07-05 21:29:21,349 25 WARNING db_1790778 odoo.modules.loading: Transient module states were reset
2024-07-05 21:29:21,350 25 ERROR db_1790778 odoo.modules.registry: Failed to load registry
Traceback (most recent call last):
File "/home/odoo/src/odoo/12.0/odoo/modules/registry.py", line 87, in new
odoo.modules.load_modules(registry._db, force_demo, status, update_module)
File "/home/odoo/src/odoo/12.0/odoo/modules/loading.py", line 362, in load_modules
report=report, models_to_check=models_to_check)
File "/home/odoo/src/odoo/12.0/odoo/modules/loading.py", line 177, in load_module_graph
migrations.migrate_module(package, 'pre')
File "/home/odoo/src/odoo/12.0/odoo/modules/migration.py", line 202, in migrate_module
migrate(self.cr, installed_version)
File "/home/odoo/src/odoo/12.0/odoo/addons/base/maintenance/migrations/base/0.0.0/pre-user-crypt-password.py", line 12, in migrate
util.remove_field(cr, "res.users", "password_crypt")
File "/home/odoo/src/odoo/12.0/odoo/addons/base/maintenance/migrations/util/fields.py", line 206, in remove_field
_remove_import_export_paths(cr, model, fieldname)
File "/home/odoo/src/odoo/12.0/odoo/addons/base/maintenance/migrations/util/records.py", line 506, in _remove_import_export_paths
cr.execute(query)
File "/home/odoo/src/odoo/12.0/odoo/sql_db.py", line 148, in wrapper
return f(self, *args, **kwargs)
File "/home/odoo/src/odoo/12.0/odoo/sql_db.py", line 225, in execute
res = self._obj.execute(query, params)
psycopg2.errors.UndefinedTable: relation "base_import_mapping" does not exist
LINE 5: FROM base_import_mapping

help me, please @pauloamed @andreabak

[augustoPerez]

Hello @desdelinux

I appologise for the inconvenience.

It seems like you found a workaround to avoid the traceback and your production upgrade in progress.

Could you confirm us if everything okay with this at the moment or if you need our intervention on the matter?
If at the moment there are more issues arising from this new changes, we will investigate it on Monday.

Have a nice day!