[IMP] report: open chat window post upgrade #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
diagnoza
commented
Feb 27, 2025
src/util/report.py
Outdated
| @@ -286,6 +286,21 @@ def ref(xid): | |||
| except Exception: | |||
| _logger.warning("Cannot announce message", exc_info=True) | |||
|
|
|||
| # Chat window with the report will be open post-upgrade for the admin | |||
| if version_gte("9.0"): | |||
There was a problem hiding this comment.
We can get rid of one level of ifs in favor of a dictionary with versions, but I thought it's going to be less readable.
There was a problem hiding this comment.
You can get rid of this because we do not support upgrading to 9.0 already :)
aj-fuentes
reviewed
Feb 28, 2025
src/util/report.py
Outdated
| [("partner_id", "=", user.partner_id.id), ("channel_id", "=", recipient.id)] | ||
| )[0].with_context(ctx).fold_state = "open" | ||
| except Exception: | ||
| _logger.warning("Cannot open chat window", exc_info=True) |
There was a problem hiding this comment.
I don't think we need to log anything, in any case if we do logging exception info is better done with _logger.exception ;)
Suggested change
| _logger.warning("Cannot open chat window", exc_info=True) | |
| pass |
Maybe use contextlib.suppress and be more specific: what kind of exception we get here? and why?
KangOl
reviewed
Feb 28, 2025
diagnoza
force-pushed
the
master-open_chat-owi
branch
from
ecf96b7 to
4926bd1
Compare
|
upgradeci retry with always only hr in all versions |
diagnoza
force-pushed
the
master-open_chat-owi
branch
from
4926bd1 to
5284593
Compare
KangOl
reviewed
Mar 3, 2025
src/util/report.py
Outdated
Comment on lines
292
to
297
| try: | ||
| registry[channel_member_model].search( | ||
| [("partner_id", "=", user.partner_id.id), ("channel_id", "=", recipient.id)] | ||
| )[0].with_context(ctx).fold_state = "open" | ||
| except Exception: | ||
| _logger.exception("Could not open chat window with upgrade report.") |
There was a problem hiding this comment.
1/ extract the domain in a variable
2/ avoid exception by not using [0]
Suggested change
| try: | |
| registry[channel_member_model].search( | |
| [("partner_id", "=", user.partner_id.id), ("channel_id", "=", recipient.id)] | |
| )[0].with_context(ctx).fold_state = "open" | |
| except Exception: | |
| _logger.exception("Could not open chat window with upgrade report.") | |
| domain = [("partner_id", "=", user.partner_id.id), ("channel_id", "=", recipient.id)] | |
| registry[channel_member_model].search(domain)[:1].with_context(ctx).fold_state = "open" |
diagnoza
force-pushed
the
master-open_chat-owi
branch
from
5284593 to
f3e72ee
Compare
KangOl
requested changes
Mar 17, 2025
src/util/report.py
Outdated
| @@ -286,6 +286,12 @@ def ref(xid): | |||
| except Exception: | |||
| _logger.warning("Cannot announce message", exc_info=True) | |||
|
|
|||
| # Chat window with the report will be open post-upgrade for the admin user | |||
| if not version_gte("saas~18.2"): | |||
| channel_member_model = "discuss.channel.member" if version_gte("saas~16.3") else "mail.channel.member" | |||
There was a problem hiding this comment.
Suggested change
| channel_member_model = "discuss.channel.member" if version_gte("saas~16.3") else "mail.channel.member" | |
| channel_member_model = "discuss.channel.member" if version_gte("saas~16.3") else "mail.channel.member" if version_gte("16.0") else "mail.channel.partner" |
src/util/report.py
Outdated
| @@ -286,6 +286,12 @@ def ref(xid): | |||
| except Exception: | |||
| _logger.warning("Cannot announce message", exc_info=True) | |||
|
|
|||
| # Chat window with the report will be open post-upgrade for the admin user | |||
| if not version_gte("saas~18.2"): | |||
There was a problem hiding this comment.
fold_state appears in v9
Suggested change
| if not version_gte("saas~18.2"): | |
| if version_between("9.0", "saas~18.2"): |
Chat window with the report will be opened by default after the upgrade, only for the admin user.
diagnoza
force-pushed
the
master-open_chat-owi
branch
from
f3e72ee to
815bece
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chat window with the report will be opened by default after the upgrade, only for the admin user.