-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC][IMP] modules, models: remove inherits #221
base: master
Are you sure you want to change the base?
Conversation
This is inspired by https://github.com/odoo/upgrade/pull/7280 |
64b2f1f
to
9a2eb3e
Compare
upgradeci retry with always only account |
In principle this should be the default behaviour. However that would break backwards compatibility with code that used to deal with the inherits after the removal of the module/model. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since removing inherits may require, or have required, some extra steps, I believe that adding a new flag (False by default) is the best option.
When removing a module, all its models (and their fields) are also removed. However inherits of such models had to be cleaned up manually.
9a2eb3e
to
45921f4
Compare
In order to catch all potential issues: (that will take a while...) |
When removing a module, all its models (and their fields) are also removed. However inherits of such models had to be cleaned up manually.