[IMP] util/misc: dynamic literal_replace #231
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
upgradeci retry with always only hr |
KangOl
reviewed
Mar 11, 2025
KangOl
reviewed
Mar 11, 2025
aj-fuentes
force-pushed
the
master-imp_literal_replace2-afu
branch
4 times, most recently
from
6cdae5f to
889bd3e
Compare
|
upgradeci retry |
|
All green \o/ |
|
I will squash the commits |
aj-fuentes
force-pushed
the
master-imp_literal_replace2-afu
branch
from
889bd3e to
2ddbdd8
Compare
|
Still all green :D |
aj-fuentes
force-pushed
the
master-imp_literal_replace2-afu
branch
from
2ddbdd8 to
4cba112
Compare
Allow to match in a glob-like fashion and produce the replacement node dynamically. Improvements: * Do not replace if no update happens (allows to write less to the DB.) * Do not buble syntax errors, log instead. * Most valid nodes for Python expressions in the ORM are covered. * Implement node matching in same order as the reference below. * Much higher test coverage. * Adapt tests for Python3.6 (Odoo 13 and 14) See: https://greentreesnakes.readthedocs.io/en/latest/nodes.html
aj-fuentes
force-pushed
the
master-imp_literal_replace2-afu
branch
from
4cba112 to
db4217a
Compare
Before it was impossible to handle domains defined as
`context.get('key') and [<dom1>] or [<dom2>]`
Example:
```
context.get('default_move_type') in ('out_invoice', 'out_refund', 'out_receipt') and [('sale_ok', '=', True), '|', ('company_id', '=', False), ('company_id', '=', parent.company_id)] or [('purchase_ok', '=', True), '|', ('company_id', '=', False), ('company_id', '=', parent.company_id)]
```
aj-fuentes
force-pushed
the
master-imp_literal_replace2-afu
branch
from
db4217a to
5ca2131
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to match in a glob-like fashion and produce the replacement node
dynamically.
Improvements: