Add support for ES6 in a pre-bundle state [PLAT-20611] #29
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dashboard runs `gulp bundle` and can get in a state where ES6 code exists prior to that bundling. [Uglify does not handle ES6](mishoo/UglifyJS#659 (comment)), so we need to ensure that Babel transpiles it.
jacobroufa
changed the title
shanewwarren
approved these changes
Aug 13, 2019
dustinsoftware
approved these changes
Aug 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dashboard runs
gulp bundleand can get in a state where ES6 code exists prior to that bundling. Uglify does not handle ES6, so we need to ensure that Babel transpiles it.PLAT-20611