Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development environment improvements and clarifications #688

Merged
merged 1 commit into from
Mar 10, 2025
Merged

Conversation

mauvilsa
Copy link
Member

@mauvilsa mauvilsa commented Mar 6, 2025

What does this PR do?

  • Update contribution guidelines.
  • Added default python version for pre-commit.
  • Don't test python 3.8 in mac and windows.

Before submitting

  • Did you read the contributing guideline?
  • Did you update the documentation? (readme and public docstrings)
  • [n/a] Did you write unit tests such that there is 100% coverage on related code? (required for bug fixes and new features)
  • Did you verify that new and existing tests pass locally?
  • Did you make sure that all changes preserve backward compatibility?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

- Added default python version for pre-commit.
- Don't test python 3.8 in mac and windows.
@mauvilsa mauvilsa added the refactor Improvements to the quality of the code label Mar 6, 2025
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ec382f1) to head (68567c2).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #688   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         6688      6688           
=========================================
  Hits          6688      6688           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Mar 6, 2025

@PabloLION
Copy link
Contributor

Sorry for the delay. With Python 3.13.1, I tested both pytest (0 fails) and tox.

Desipte ignoring jsonnet and jsonnet-binary, I think you might've forgotten jsonnet-sdist. And its building process is still failing, with similar error message as before.

Ignoring jsonnet-binary: markers 'os_name != "posix" and python_version < "3.13"' don't match your environment
Ignoring jsonnet: markers 'os_name == "posix" and python_version < "3.13"' don't match your environment
Ignoring typing-extensions: markers 'python_version < "3.10"' don't match your environment
...
      error: invalid argument '-std=c++17' not allowed with 'C'
      error: command '/usr/bin/clang' failed with exit code 1
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for jsonnet-sdist
ERROR: Failed to build installable wheels for some pyproject.toml based projects (jsonnet-sdist)

@mauvilsa
Copy link
Member Author

@PabloLION thank you for looking at this. Regarding jsonnet, this will only be fixed once the new release v0.21 comes out, see #682.

@mauvilsa mauvilsa merged commit 745eac8 into main Mar 10, 2025
30 checks passed
@mauvilsa mauvilsa deleted the dev-env branch March 10, 2025 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Improvements to the quality of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants