Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] _init_dist_slurm can fail if scontrol gives a warning #1970

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

TimDarcet
Copy link

@TimDarcet TimDarcet commented May 18, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

subprocess.getoutput also returns stderr. If scontrol issues a warning, the variable addr will include this warning.
Using subprocess.check_output fixes this.
Reference:
[1]:https://docs.python.org/2/library/subprocess.html#subprocess.check_output

Modification

Use subprocess.check_output instead of subprocess.getoutput in mmcv.runner._init_dist_slurm

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

subprocess.getoutput also returns stderr. If scontrol issues a warning, the variable addr will include this warning
@CLAassistant
Copy link

CLAassistant commented May 18, 2022

CLA assistant check
All committers have signed the CLA.

@imabackstabber
Copy link
Contributor

Thanks for your contribution.I add a ref link,which explain subprocess.check_output.

Copy link
Contributor

@imabackstabber imabackstabber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@imabackstabber
Copy link
Contributor

maybe need to fix some lint @TimDarcet

@imabackstabber
Copy link
Contributor

maybe need to fix some lint @TimDarcet

I change it anyway.

@ZwwWayne
Copy link
Collaborator

unit tests failed

@OpenMMLab-Assistant-004

Hi @TimDarcet !We are grateful for your efforts in helping improve mmcv open-source project during your personal time.
Welcome to join OpenMMLab Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA
If you have a WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants