v5: Fix singleton spawn #10716
Merged
v5: Fix singleton spawn #10716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* See openpmix/openpmix#2705 Signed-off-by: Joshua Hursey <[email protected]> (cherry picked from commit 245424c)
* Fixes open-mpi#10590 * Singletons will not have a PMIx value for `PMIX_LOCAL_PEERS` so make that optional instead of required. * `&` is being confused as an application argument in `prte` instead of the background character * Replace with `--daemonize` which is probably better anyway Signed-off-by: Joshua Hursey <[email protected]> (cherry picked from commit 16a1fa6)
When doing a comm_spawn as a singleton, you need to instruct the "prte" DVM to forward any IO from the child job to the singleton "parent" so it can be properly output. Otherwise, the IO from the child job will simply be lost. Signed-off-by: Ralph Castain <[email protected]> (cherry picked from commit 48dbd1d)
|
bot:aws:retest |
awlauria
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.