Put back old common protos #357
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewparmet
commented
Mar 14, 2025
| @file:Suppress("DEPRECATION") | ||
| @file:JvmName("Field_maskKt") |
There was a problem hiding this comment.
No change to ABI.
| @file:Suppress("DEPRECATION") | ||
| @file:JvmName("Source_contextKt") |
There was a problem hiding this comment.
No change to ABI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And fix Spotless configuration since it was throwing a huge fit and I didn't want to use the old style of duplicating exclusions everywhere from parent projects.
This change will re-pollute the classpaths of downstream projects with classes that conflict with those generated by protobuf-java. My current thought is that we can split these out into
-legacymodules that consumers can import if they need the runtime dependencies so new projects have clean classpaths and don't have to exclude anything.