Aligns to Open Source 2.4.7-p3 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-kl1
reviewed
Jan 15, 2025
thomas-kl1
reviewed
Jan 15, 2025
thomas-kl1
requested changes
Jan 15, 2025
|
Thank you @LucaGallinari for your great contribution ❤️ I've noted that it's still in draft, but here my comments anyway 😄 |
|
Yes, i am working on it locally while we are doing a sidegrade, i'll comeback with some more changes |
…primary key in EE and the OpenSource primary key is made of value and entity ids
LucaGallinari
commented
Feb 6, 2025
LucaGallinari
force-pushed
the
patch-2
branch
from
22a615c to
5eda87f
Compare
|
Ok, that's all! It's ready for review |
|
woaw @LucaGallinari amazing work here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll comeback tomorrow with more insight regarding this PR 😄