Skip to content

Copy File Definition: Process multiple objects with single api request #3163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 23, 2025

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Apr 21, 2025

Depends on core PR: openhab/openhab-core#4734

This solves the problem with YAML format returning the version and things (or items) keys for each item in multi-select requests. By combining them into a single request, only one key will be returned at the top.

See discussion in #3130 (comment)

Copy link

relativeci bot commented Apr 21, 2025

#3059 Bundle Size — 11.19MiB (-0.01%).

62cdc9b(current) vs 19c3a42 main#3050(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Improvement 1 improvement
                 Current
#3059
     Baseline
#3050
Improvement  Initial JS 2MiB(-0.07%) 2.01MiB
No change  Initial CSS 577.53KiB 577.53KiB
Change  Cache Invalidation 18.78% 20.43%
No change  Chunks 250 250
No change  Assets 273 273
No change  Modules 2975 2975
No change  Duplicate Modules 151 151
No change  Duplicate Code 1.74% 1.74%
No change  Packages 97 97
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
#3059
     Baseline
#3050
Improvement  JS 9.4MiB (-0.02%) 9.4MiB
No change  CSS 867.92KiB 867.92KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch jimtng:copy-text-file-bulkProject dashboard


Generated by RelativeCIDocumentationReport issue

@jimtng jimtng force-pushed the copy-text-file-bulk branch from 962fb9e to ee4faf4 Compare April 21, 2025 05:21
@lolodomo
Copy link
Contributor

Now that the core PR is merged, the feature is broken until this UI PR is also merged.

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, thanks!
I will trust you that this works.

@florian-h05 florian-h05 changed the title Copy File Definition: process multiple objects with a single api request Copy File Definition: Process multiple objects with single api request Apr 23, 2025
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Apr 23, 2025
@florian-h05 florian-h05 added this to the 5.0 milestone Apr 23, 2025
@florian-h05 florian-h05 merged commit c9c4ab6 into openhab:main Apr 23, 2025
5 checks passed
@jimtng jimtng deleted the copy-text-file-bulk branch April 23, 2025 23:51
@jimtng
Copy link
Contributor Author

jimtng commented Apr 24, 2025

I've just tried the latest snapshot. It seems to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants