8352615: [Test] RISC-V: TestVectorizationMultiInvar.java fails on riscv64 without rvv support

[Hamlin-Li]

Hi,
Can you help to review this trivial patch?
TestVectorizationMultiInvar.java fails on riscv if rvv is not support, as it will verify the MaxVectorSize > 0 in test framework.

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8352615: [Test] RISC-V: TestVectorizationMultiInvar.java fails on riscv64 without rvv support (Bug - P4)

Reviewers

• Fei Yang (@RealFYang - Reviewer)
• Robbin Ehn (@robehn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24157/head:pull/24157
$ git checkout pull/24157

Update a local copy of the PR:
$ git checkout pull/24157
$ git pull https://git.openjdk.org/jdk.git pull/24157/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24157

View PR using the GUI difftool:
$ git pr show -t 24157

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24157.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352615: [Test] RISC-V: TestVectorizationMultiInvar.java fails on riscv64 without rvv support

Reviewed-by: fyang, rehn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• a875733: 8352486: [ubsan] compilationMemoryStatistic.cpp:659:21: runtime error: index 64 out of bounds for type const struct unnamed struct
• 5591f8a: 8351515: C2 incorrectly removes double negation for double and float
• 56a4ffa: 8352597: [IR Framework] test bug: TestNotCompilable.java fails on product build
• e23e0f8: 8352591: Missing UnlockDiagnosticVMOptions in VerifyGraphEdgesWithDeadCodeCheckFromSafepoints test
• adfb120: 8351748: Add class init barrier to AOT-cached Method/Var Handles
• ee1577b: 8352652: [BACKOUT] nsk/jvmti/ tests should fail when nsk_jvmti_setFailStatus() is called
• df9210e: 8347706: jvmciEnv.cpp has jvmci includes out of order
• 5dd0acb: 8352477: RISC-V: Print warnings when unsupported intrinsics are enabled
• 334a1ee: 8351375: nsk/jvmti/ tests should fail when nsk_jvmti_setFailStatus() is called
• 7442039: 8337279: Share StringBuilder to format instant
• ... and 4 more: https://git.openjdk.org/jdk/compare/0cb110ebb7f8d184dd855f64c5dd7924c8202b3d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@Hamlin-Li The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (304f0fad)

[RealFYang]

Looks good. Seems this won't menifest on riscv64 platforms where AlignVector is true.

[robehn]

Thanks

[Hamlin-Li]

Looks good. Seems this won't menifest on riscv64 platforms where AlignVector is true.

Thank you!

Yes, there is a !((Boolean)alignVector) condition to really run the test.

[Hamlin-Li]

Thanks

Thank you!

[Hamlin-Li]

/integrate

[openjdk]

Going to push as commit b84b292.
Since your change was applied there have been 22 commits pushed to the master branch:

• a54445f: 8350609: Cleanup unknown unwind opcode (0xB) for windows
• c87e1be: 8349582: APX NDD code generation for OpenJDK
• 7d1fe0e: 8339543: [vectorapi] laneHelper and withLaneHelper should be ForceInline
• ddc4318: 8352628: Refine Grapheme test
• d8c2f59: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher
• 5709f79: 8352648: JFR: 'jfr query' should not be available in product builds
• 02a4ce2: 8352147: G1: TestEagerReclaimHumongousRegionsClearMarkBits test takes very long
• de58009: 8351468: C2: array fill optimization assigns wrong type to intrinsic call
• a875733: 8352486: [ubsan] compilationMemoryStatistic.cpp:659:21: runtime error: index 64 out of bounds for type const struct unnamed struct
• 5591f8a: 8351515: C2 incorrectly removes double negation for double and float
• ... and 12 more: https://git.openjdk.org/jdk/compare/0cb110ebb7f8d184dd855f64c5dd7924c8202b3d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@Hamlin-Li Pushed as commit b84b292.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.