8352618: Remove old deprecated functionality in the build system

[magicus]

It's time for some spring cleaning in the build system. These checks are for functionality that has long been deprecated, and should not be in use anymore. We should remove it to keep the code base simpler.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8352618: Remove old deprecated functionality in the build system (Enhancement - P4)

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)
• Kim Barrett (@kimbarrett - Reviewer)
• Julian Waters (@TheShermanTanker - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24159/head:pull/24159
$ git checkout pull/24159

Update a local copy of the PR:
$ git checkout pull/24159
$ git pull https://git.openjdk.org/jdk.git pull/24159/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24159

View PR using the GUI difftool:
$ git pr show -t 24159

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24159.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352618: Remove old deprecated functionality in the build system

Reviewed-by: erikj, kbarrett, jwaters

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

• 52c6ce6: 8352091: GenShen: assert(!(request.generation->is_old() && _heap->old_generation()->is_doing_mixed_evacuations())) failed: Old heuristic should not request cycles while it waits for mixed evacuation
• b8f3856: 8352420: [ubsan] codeBuffer.cpp:984:27: runtime error: applying non-zero offset 18446744073709486080 to null pointer
• 0cb110e: 8350892: [JVMCI] Align ResolvedJavaType.getInstanceFields with Class.getDeclaredFields
• 04eac0c: 8352159: RISC-V: add more zfa support
• ac760dd: 8352423: RISC-V: simplify DivI/L ModI/L
• d1cf232: 8352248: Check if CMoveX is supported
• 2b55979: 8352529: RISC-V: enable loopopts tests
• 8469458: 8352511: Show additional level of headings in table of contents
• 28250f8: 8352151: Fix display issues in javadoc-generated docs
• b32be18: 8352178: Add precondition in VMThread::execute to prevent deadlock
• ... and 11 more: https://git.openjdk.org/jdk/compare/96305e0953a2a3b41bc32b1c584a1a29901a37fd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@magicus The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (0364834c)

[kimbarrett]

Nice cleanup.

[TheShermanTanker]

Go for it!

[magicus]

/integrate

[openjdk]

Going to push as commit bab9372.
Since your change was applied there have been 61 commits pushed to the master branch:

• 512b9b1: 8196896: Use SYSROOT_CFLAGS in dtrace gensrc
• 721ef76: 8352696: JFR: assert(false): EA: missing memory path
• c002b97: 8352676: Opensource JMenu tests - series1
• bdcac98: 8347459: C2: missing transformation for chain of shifts/multiplications by constants
• 3d3b782: 8352607: RISC-V: use cmove in min/max when Zicond is supported
• 9f582e5: 8320997: RISC-V: C2 ReverseV
• 6879c44: 8351405: G1: Collection set early pruning causes suboptimal region selection
• aee4d69: 8348829: Remove ObjectMonitor perf counters
• f9bcef4: 8351627: C2 AArch64 ROR/ROL: assert((1 << ((T>>1)+3)) > shift) failed: Invalid Shift value
• 17dc30c: 8352414: JFR: JavaMonitorDeflateEvent crashes when deflated monitor object is dead
• ... and 51 more: https://git.openjdk.org/jdk/compare/96305e0953a2a3b41bc32b1c584a1a29901a37fd...master

Your commit was automatically rebased without conflicts.

[openjdk]

@magicus Pushed as commit bab9372.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.