Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8352595: Regression of JDK-8314999 in IR matching #24163

Closed
wants to merge 6 commits into from
Closed

8352595: Regression of JDK-8314999 in IR matching #24163

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4c7ed17
Fix TestBadFormat
marc-chevalier Mar 21, 2025
ee3cc6f
Fix TestPhaseIRMatching.java
marc-chevalier Mar 21, 2025
17e11d4
Fix TestCompilePhaseCollector.java
marc-chevalier Mar 21, 2025
98febc9
wip
marc-chevalier Mar 24, 2025
b125df8
wip
marc-chevalier Mar 24, 2025
c7c0cfa
Merge branch 'master' into fix/fix-IRframework-test
marc-chevalier Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestBadFormat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1163,15 +1163,17 @@ public void machNode() {}
public void duplicatedPhase() {}

@Test
@FailCount(4)
@IR(failOn = IRNode.ALLOC, phase = {CompilePhase.FINAL_CODE, CompilePhase.AFTER_MACRO_EXPANSION})
@IR(failOn = IRNode.ALLOC, phase = CompilePhase.PRINT_IDEAL)
@FailCount(6)
@IR(failOn = IRNode.ALLOC, phase = {CompilePhase.FINAL_CODE, CompilePhase.AFTER_MACRO_EXPANSION}) // FINAL_CODE not available
@IR(failOn = IRNode.ALLOC, phase = CompilePhase.PRINT_IDEAL) // PRINT_IDEAL not available
@IR(failOn = IRNode.ALLOC, phase = {CompilePhase.ITER_GVN1, CompilePhase.AFTER_PARSING}) // works
@IR(failOn = IRNode.ALLOC, phase = {CompilePhase.ITER_GVN1, CompilePhase.AFTER_PARSING,
CompilePhase.PRINT_OPTO_ASSEMBLY}) // works
@IR(failOn = IRNode.ALLOC_ARRAY, phase = {CompilePhase.FINAL_CODE, CompilePhase.AFTER_MACRO_EXPANSION})
@IR(failOn = IRNode.ALLOC_ARRAY, phase = CompilePhase.PRINT_IDEAL)
CompilePhase.PRINT_OPTO_ASSEMBLY}) // PRINT_OPTO_ASSEMBLY not available
@IR(failOn = IRNode.ALLOC_ARRAY, phase = {CompilePhase.FINAL_CODE, CompilePhase.AFTER_MACRO_EXPANSION}) // FINAL_CODE not available
@IR(failOn = IRNode.ALLOC_ARRAY, phase = CompilePhase.PRINT_IDEAL) // PRINT_IDEAL not available
@IR(failOn = IRNode.ALLOC_ARRAY, phase = {CompilePhase.ITER_GVN1, CompilePhase.AFTER_PARSING}) // works
@IR(failOn = IRNode.ALLOC_ARRAY, phase = {CompilePhase.ITER_GVN1, CompilePhase.AFTER_PARSING,
CompilePhase.PRINT_OPTO_ASSEMBLY}) // works
CompilePhase.PRINT_OPTO_ASSEMBLY}) // PRINT_OPTO_ASSEMBLY not available
public void alloc() {}

@Test
Expand Down
51 changes: 31 additions & 20 deletions test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestPhaseIRMatching.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,16 @@ class Basics {
Object obj3;
Object obj4;

public class Helper {
private String s;

public Helper(String s, int i) {
this.s = s;
}

public String getString() { return s; }
}

@Test
@IR(failOn = IRNode.STORE, phase = {CompilePhase.DEFAULT, CompilePhase.PRINT_IDEAL})
@ExpectedFailure(ruleId = 1, failOn = 1) // Only one failure - remove duplicated phases after mapping DEFAULT
Expand All @@ -118,14 +128,14 @@ public void removeDuplicates() {
@IR(failOn = {IRNode.STORE, IRNode.ALLOC, IRNode.COUNTED_LOOP},
counts = {IRNode.STORE, "3", IRNode.ALLOC, "1", IRNode.COUNTED_LOOP, "2"})
@ExpectedFailure(ruleId = 1, phase = CompilePhase.PRINT_IDEAL, failOn = 1, counts = {1, 3})
@ExpectedFailure(ruleId = 1, phase = CompilePhase.PRINT_OPTO_ASSEMBLY, counts = 2)
@ExpectedFailure(ruleId = 1, phase = CompilePhase.BEFORE_MACRO_EXPANSION, counts = 2)

@IR(failOn = {IRNode.STORE, IRNode.ALLOC, IRNode.COUNTED_LOOP})
@ExpectedFailure(ruleId = 2, phase = CompilePhase.PRINT_IDEAL, failOn = 1)

@IR(counts = {IRNode.STORE, "3", IRNode.ALLOC, "1", IRNode.COUNTED_LOOP, "2"})
@ExpectedFailure(ruleId = 3, phase = CompilePhase.PRINT_IDEAL, counts = {1, 3})
@ExpectedFailure(ruleId = 3, phase = CompilePhase.PRINT_OPTO_ASSEMBLY, counts = 2)
@ExpectedFailure(ruleId = 3, phase = CompilePhase.BEFORE_MACRO_EXPANSION, counts = 2)

@IR(counts = {IRNode.STORE_I, "2"})
@ExpectedFailure(ruleId = 4, phase = CompilePhase.PRINT_IDEAL, counts = 1)
Expand All @@ -135,50 +145,50 @@ public void defaultOnIdeal() {
}

@Test
@IR(failOn = {IRNode.STORE_F, IRNode.ALLOC, IRNode.COUNTED_LOOP},
counts = {IRNode.STORE_F, "3", IRNode.ALLOC, "1", IRNode.COUNTED_LOOP, "2"})
@IR(failOn = {IRNode.STORE_F, IRNode.FIELD_ACCESS, IRNode.COUNTED_LOOP},
counts = {IRNode.STORE_F, "3", IRNode.FIELD_ACCESS, "1", IRNode.COUNTED_LOOP, "2"})
@ExpectedFailure(ruleId = 1, phase = CompilePhase.PRINT_OPTO_ASSEMBLY, failOn = 2)
@ExpectedFailure(ruleId = 1, phase = CompilePhase.PRINT_IDEAL, counts = {1, 3})

@IR(failOn = {IRNode.STORE_F, IRNode.ALLOC, IRNode.COUNTED_LOOP})
@IR(failOn = {IRNode.STORE_F, IRNode.FIELD_ACCESS, IRNode.COUNTED_LOOP})
@ExpectedFailure(ruleId = 2, phase = CompilePhase.PRINT_OPTO_ASSEMBLY, failOn = 2)

@IR(counts = {IRNode.STORE_F, "3", IRNode.ALLOC, "1", IRNode.COUNTED_LOOP, "2"})
@IR(counts = {IRNode.STORE_F, "3", IRNode.FIELD_ACCESS, "1", IRNode.COUNTED_LOOP, "2"})
@ExpectedFailure(ruleId = 3, phase = CompilePhase.PRINT_IDEAL, counts = {1, 3})

@IR(failOn = {IRNode.STORE_F, IRNode.ALLOC, IRNode.COUNTED_LOOP},
counts = {IRNode.STORE_F, "3", IRNode.ALLOC, "2", IRNode.COUNTED_LOOP, "2"})
@IR(failOn = {IRNode.STORE_F, IRNode.FIELD_ACCESS, IRNode.COUNTED_LOOP},
counts = {IRNode.STORE_F, "3", IRNode.FIELD_ACCESS, "2", IRNode.COUNTED_LOOP, "2"})

@ExpectedFailure(ruleId = 4, phase = CompilePhase.PRINT_OPTO_ASSEMBLY, failOn = 2, counts = 2)
@ExpectedFailure(ruleId = 4, phase = CompilePhase.PRINT_IDEAL, counts = {1, 3})

@IR(counts = {IRNode.ALLOC, "2"})
@IR(counts = {IRNode.FIELD_ACCESS, "2"})
@ExpectedFailure(ruleId = 5, phase = CompilePhase.PRINT_OPTO_ASSEMBLY, counts = 1)
public Object defaultOnOptoAssembly() {
return new Object();
public Object defaultOnOptoAssembly(Helper h) {
return h.getString();
}

@Test
@IR(failOn = {IRNode.STORE, IRNode.ALLOC, IRNode.ALLOC_OF, "Object", IRNode.COUNTED_LOOP},
counts = {IRNode.STORE, "20", IRNode.ALLOC, "1", IRNode.ALLOC_OF, "Object", "1", IRNode.COUNTED_LOOP, "2"})
@ExpectedFailure(ruleId = 1, phase = CompilePhase.PRINT_OPTO_ASSEMBLY, failOn = {2, 3})
@ExpectedFailure(ruleId = 1, phase = CompilePhase.BEFORE_MACRO_EXPANSION, failOn = {2, 3})
@ExpectedFailure(ruleId = 1, phase = CompilePhase.PRINT_IDEAL, failOn = 1, counts = {1, 4})

@IR(failOn = {IRNode.STORE, IRNode.ALLOC, IRNode.ALLOC_OF, "Object", IRNode.COUNTED_LOOP})
@ExpectedFailure(ruleId = 2, phase = CompilePhase.PRINT_IDEAL, failOn = 1)
@ExpectedFailure(ruleId = 2, phase = CompilePhase.PRINT_OPTO_ASSEMBLY, failOn = {2, 3})
@ExpectedFailure(ruleId = 2, phase = CompilePhase.BEFORE_MACRO_EXPANSION, failOn = {2, 3})

@IR(counts = {IRNode.STORE, "20", IRNode.ALLOC, "1", IRNode.ALLOC_OF, "Object", "2", IRNode.COUNTED_LOOP, "2"})
@ExpectedFailure(ruleId = 3, phase = CompilePhase.PRINT_IDEAL, counts = {1, 4})
@ExpectedFailure(ruleId = 3, phase = CompilePhase.PRINT_OPTO_ASSEMBLY, counts = 3)
@ExpectedFailure(ruleId = 3, phase = CompilePhase.BEFORE_MACRO_EXPANSION, counts = 3)

@IR(failOn = {IRNode.STORE, IRNode.ALLOC, IRNode.ALLOC_OF, "Object", IRNode.COUNTED_LOOP},
counts = {IRNode.STORE, "20", IRNode.ALLOC, "2", IRNode.ALLOC_OF, "Object", "2", IRNode.COUNTED_LOOP, "2"})
@ExpectedFailure(ruleId = 4, phase = CompilePhase.PRINT_OPTO_ASSEMBLY, failOn = {2, 3}, counts = {2, 3})
@ExpectedFailure(ruleId = 4, phase = CompilePhase.BEFORE_MACRO_EXPANSION, failOn = {2, 3}, counts = {2, 3})
@ExpectedFailure(ruleId = 4, phase = CompilePhase.PRINT_IDEAL, failOn = 1, counts = {1, 4})

@IR(counts = {IRNode.ALLOC, "2", IRNode.ALLOC_OF, "Object", "1"})
@ExpectedFailure(ruleId = 5, phase = CompilePhase.PRINT_OPTO_ASSEMBLY, counts = 1)
@ExpectedFailure(ruleId = 5, phase = CompilePhase.BEFORE_MACRO_EXPANSION, counts = 1)
public void defaultOnBoth() {
Copy link
Member

@chhagedorn chhagedorn Mar 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for this test you should add a matching on some PrintOptoAssembly as well since it tries to verify ideal and opto matching.

obj = new Object();
}
Expand All @@ -202,7 +212,7 @@ public int removeLoopsWithMultipleCompilations(int k) {
return x;
}

@Run(test = "removeLoopsWithMultipleCompilations")
@Run(test = {"removeLoopsWithMultipleCompilations", "defaultOnOptoAssembly"})
@Warmup(1)
public void run() {
for (int i = 0; i < 10000; i++) {
Expand All @@ -211,6 +221,7 @@ public void run() {
for (int i = 0; i < 10000; i++) {
removeLoopsWithMultipleCompilations(3);
}
defaultOnOptoAssembly(new Helper("a", 1));
}

@Test
Expand Down Expand Up @@ -238,17 +249,17 @@ public int limit() {
@Test
@IR(failOn = {IRNode.ALLOC, IRNode.ALLOC_ARRAY},
counts = {IRNode.ALLOC, "0", IRNode.ALLOC_ARRAY, "0"},
phase = {CompilePhase.BEFORE_REMOVEUSELESS, CompilePhase.CCP1, CompilePhase.PRINT_OPTO_ASSEMBLY, CompilePhase.DEFAULT})
phase = {CompilePhase.BEFORE_REMOVEUSELESS, CompilePhase.CCP1, CompilePhase.DEFAULT})
@ExpectedFailure(ruleId = 1, failOn = {1, 2}, counts = {1, 2},
phase = {CompilePhase.BEFORE_REMOVEUSELESS, CompilePhase.CCP1, CompilePhase.PRINT_OPTO_ASSEMBLY})
phase = {CompilePhase.BEFORE_REMOVEUSELESS, CompilePhase.CCP1, CompilePhase.BEFORE_MACRO_EXPANSION})
public void alloc() {
obj = new Object();
obj2 = new Object[1];
}

@Test
@IR(counts = {IRNode.ALLOC, "2", IRNode.ALLOC_ARRAY, "2"}, // works for all phases
phase = {CompilePhase.BEFORE_REMOVEUSELESS, CompilePhase.CCP1, CompilePhase.PRINT_OPTO_ASSEMBLY, CompilePhase.DEFAULT})
phase = {CompilePhase.BEFORE_REMOVEUSELESS, CompilePhase.CCP1, CompilePhase.DEFAULT})
public void alloc2() {
obj = new Object();
obj2 = new Object[1];
Expand Down
63 changes: 32 additions & 31 deletions test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/flag/TestCompilePhaseCollector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,12 +113,12 @@ public void testMixedPhases() {
assertContainsOnly(methodToCompilePhases, testClass, "mix7", PHASEIDEALLOOP1, PHASEIDEALLOOP2, FINAL_CODE,
OPTIMIZE_FINISHED, PRINT_IDEAL);
assertContainsOnly(methodToCompilePhases, testClass, "mix8", PHASEIDEALLOOP1, PHASEIDEALLOOP2, FINAL_CODE,
OPTIMIZE_FINISHED, PRINT_IDEAL, PRINT_OPTO_ASSEMBLY);
OPTIMIZE_FINISHED, PRINT_IDEAL);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the tests on this file only collect compile phases and actually do not perform any IR matching. So, the IR rules do not need work. This means that for all tests where we use the default compile phase of ALLOC (which is PRINT_OPTO_ASSEMBLY), we can replace ALLOC with just something else that defaults on PRINT_OPTO_ASSEMBLY.

This just means that we should not replace PRINT_OPTO_ASSEMBLY with BEFORE_MACRO_EXPANSION here but instead use a different IRNode in the IR rules at these tests that default on PRINT_OPTO_ASSEMBLY. I've made some comments further down where this applies. The other changes in the file look fine.

assertContainsOnly(methodToCompilePhases, testClass, "mix9", PHASEIDEALLOOP1, PHASEIDEALLOOP2, PRINT_IDEAL);
assertContainsOnly(methodToCompilePhases, testClass, "mix10", PHASEIDEALLOOP1, PHASEIDEALLOOP2, PRINT_OPTO_ASSEMBLY);
assertContainsOnly(methodToCompilePhases, testClass, "mix11", PHASEIDEALLOOP1, PHASEIDEALLOOP2, PRINT_OPTO_ASSEMBLY,
assertContainsOnly(methodToCompilePhases, testClass, "mix11", PHASEIDEALLOOP1, PHASEIDEALLOOP2, BEFORE_MACRO_EXPANSION,
FINAL_CODE, OPTIMIZE_FINISHED);
assertContainsOnly(methodToCompilePhases, testClass, "mix12", PHASEIDEALLOOP1, PHASEIDEALLOOP2, PRINT_OPTO_ASSEMBLY,
assertContainsOnly(methodToCompilePhases, testClass, "mix12", PHASEIDEALLOOP1, PHASEIDEALLOOP2,
FINAL_CODE, OPTIMIZE_FINISHED, PRINT_IDEAL);
assertContainsOnly(methodToCompilePhases, testClass, "mix13", PHASEIDEALLOOP1, PHASEIDEALLOOP2, PRINT_IDEAL,
FINAL_CODE, OPTIMIZE_FINISHED);
Expand All @@ -129,7 +129,7 @@ public void testMixedPhases() {
assertContainsOnly(methodToCompilePhases, testClass, "mix16", PHASEIDEALLOOP1, PHASEIDEALLOOP2, FINAL_CODE,
OPTIMIZE_FINISHED, PRINT_IDEAL);
assertContainsOnly(methodToCompilePhases, testClass, "mix17", PHASEIDEALLOOP1, PHASEIDEALLOOP2, FINAL_CODE,
OPTIMIZE_FINISHED, PRINT_OPTO_ASSEMBLY);
OPTIMIZE_FINISHED, PRINT_IDEAL);
}

private void testDefault(Class<?> testClass, CompilePhase... compilePhases) {
Expand All @@ -147,9 +147,9 @@ private void assertContainsOnly(Map<String, Set<CompilePhase>> methodToCompilePh
String simpleMethodName, CompilePhase... compilePhases) {
String methodName = getFullMethodName(testClass, simpleMethodName);
Set<CompilePhase> compilePhaseSet = methodToCompilePhases.get(methodName);
Assert.assertEquals("must be equal", compilePhases.length, compilePhaseSet.size());
Assert.assertEquals("In method " + simpleMethodName + ": must be equal", compilePhases.length, compilePhaseSet.size());
for (CompilePhase compilePhase : compilePhases) {
Assert.assertTrue("did not find " + compilePhase + " for " + methodName,
Assert.assertTrue("In method " + simpleMethodName + ": did not find " + compilePhase + " for " + methodName,
methodToCompilePhases.get(methodName).contains(compilePhase));
}
}
Expand Down Expand Up @@ -193,44 +193,45 @@ public void test6() {}
}

static class Opto {

@Test
@IR(failOn = IRNode.ALLOC)
@IR(counts = {IRNode.SCOPE_OBJECT, "2"})
public void test1() {}


@Test
@IR(failOn = {IRNode.ALLOC_OF, "Foo"})
@IR(counts = {IRNode.OOPMAP_WITH, "Foo", "2"})
public void test2() {}

@Test
@IR(counts = {IRNode.SCOPE_OBJECT, "2"})
@IR(failOn = IRNode.FIELD_ACCESS)
@IR(counts = {IRNode.CHECKCAST_ARRAY, "2"})
public void test3() {}

@Test
@IR(counts = {IRNode.ALLOC_ARRAY_OF, "Foo", "!= 4"})
@IR(failOn = {IRNode.CHECKCAST_ARRAYCOPY, IRNode.CHECKCAST_ARRAY_OF, "Foo"})
@IR(counts = {IRNode.CBZ_HI, "> 1"})
public void test4() {}


@Test
@IR(failOn = IRNode.FIELD_ACCESS)
@IR(counts = {IRNode.CHECKCAST_ARRAY, "2"})
@IR(failOn = {IRNode.CBNZW_HI})
@IR(counts = {IRNode.CBZ_LS, "2", IRNode.CBZW_LS, "> 1"})
public void test5() {}

@Test
@IR(failOn = {IRNode.CHECKCAST_ARRAYCOPY, IRNode.CHECKCAST_ARRAY_OF, "Foo"})
@IR(counts = {IRNode.ALLOC, "2", IRNode.ALLOC_ARRAY_OF, "Foo", "> 1"})
@IR(failOn = {IRNode.CBNZW_HI})
@IR(counts = {IRNode.CBZW_LS, "> 1"})
Comment on lines +212 to +222
Copy link
Member

@chhagedorn chhagedorn Mar 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just noticed that these AArch64 specific IRNode entries do not have a check that they are only supported on AArch64. In the past, I've added some platform checks for IRNode entries only being supported on certain platforms:

jdk/test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java

Lines 2905 to 2925 in e23e0f8

public static void checkIRNodeSupported(String node) throws CheckedTestFrameworkException {
switch (node) {
case INTRINSIC_OR_TYPE_CHECKED_INLINING_TRAP -> {
if (!WhiteBox.getWhiteBox().isJVMCISupportedByGC()) {
throw new CheckedTestFrameworkException("INTRINSIC_OR_TYPE_CHECKED_INLINING_TRAP is unsupported " +
"in builds without JVMCI.");
}
}
case CHECKCAST_ARRAYCOPY -> {
if (Platform.isS390x()) {
throw new CheckedTestFrameworkException("CHECKCAST_ARRAYCOPY is unsupported on s390.");
}
}
case IS_FINITE_D, IS_FINITE_F -> {
if (!Platform.isRISCV64()) {
throw new CheckedTestFrameworkException("IS_FINITE_* is only supported on riscv64.");
}
}
// default: do nothing -> IR node is supported and can be used by the user.
}
}

We should probably add a similar check for these CB* entries. But that's something that can be done separately.

For this test here, we only collect compile phases and it does not matter on what platforms these IRNode entries are eventually used. So, no action to be done in your changes here.

public void test6() {}
}

static class IdealAndOpto {
@Test
@IR(failOn = IRNode.ALLOC)
@IR(failOn = IRNode.FIELD_ACCESS)
@IR(failOn = IRNode.STORE)
public void test1() {}


@Test
@IR(failOn = {IRNode.ALLOC_OF, "Foo"})
@IR(failOn = {IRNode.CHECKCAST_ARRAY_OF, "Foo"})
@IR(failOn = {IRNode.STORE_OF_FIELD, "iFld"})
public void test2() {}

Expand All @@ -241,7 +242,7 @@ public void test3() {}

@Test
@IR(counts = {IRNode.LOAD_OF_FIELD, "iFld", "!= 4"})
@IR(counts = {IRNode.ALLOC_ARRAY_OF, "Foo", "!= 4"})
@IR(counts = {IRNode.OOPMAP_WITH, "Foo", "!= 4"})
public void test4() {}


Expand All @@ -254,7 +255,7 @@ public void test5() {}

@Test
@IR(failOn = {IRNode.STORE, IRNode.CHECKCAST_ARRAY_OF, "Foo"})
@IR(counts = {IRNode.ALLOC, "2", IRNode.STORE_OF_FIELD, "iFld", "> 1"})
@IR(counts = {IRNode.FIELD_ACCESS, "2", IRNode.STORE_OF_FIELD, "iFld", "> 1"})
public void test6() {}
}

Expand Down Expand Up @@ -308,7 +309,7 @@ public void test2() {}

@Test
@IR(failOn = IRNode.ALLOC, phase = AFTER_PARSING)
@IR(failOn = {IRNode.ALLOC_ARRAY_OF, "Foo"}, phase = DEFAULT)
@IR(failOn = {IRNode.OOPMAP_WITH, "Foo"}, phase = DEFAULT)
public void test3() {}

@Test
Expand All @@ -326,7 +327,7 @@ public void test6() {}

@Test
@IR(failOn = IRNode.STORE, phase = {PHASEIDEALLOOP1, PHASEIDEALLOOP2})
@IR(failOn = IRNode.ALLOC, phase = DEFAULT)
@IR(failOn = IRNode.FIELD_ACCESS, phase = DEFAULT)
@IR(failOn = IRNode.STORE, phase = {FINAL_CODE, OPTIMIZE_FINISHED})
public void test7() {}

Expand All @@ -346,7 +347,7 @@ public void test2A() {}

@Test
@IR(counts = {IRNode.ALLOC, "< 3"}, phase = AFTER_PARSING)
@IR(counts = {IRNode.ALLOC_ARRAY_OF, "Foo", ">=3"}, phase = DEFAULT)
@IR(counts = {IRNode.OOPMAP_WITH, "Foo", ">=3"}, phase = DEFAULT)
public void test3A() {}

@Test
Expand All @@ -364,7 +365,7 @@ public void test6A() {}

@Test
@IR(counts = {IRNode.STORE, "3"}, phase = {PHASEIDEALLOOP1, PHASEIDEALLOOP2})
@IR(counts = {IRNode.ALLOC, "3"}, phase = DEFAULT)
@IR(counts = {IRNode.FIELD_ACCESS, "3"}, phase = DEFAULT)
@IR(counts = {IRNode.STORE, "3"}, phase = {FINAL_CODE, OPTIMIZE_FINISHED})
public void test7A() {}

Expand All @@ -386,13 +387,13 @@ public void mix2() {}
@Test
@IR(failOn = IRNode.STORE, phase = AFTER_PARSING)
@IR(counts = {IRNode.STORE, "3"}, phase = DEFAULT)
@IR(failOn = {IRNode.ALLOC_OF, "Foo"}, phase = DEFAULT)
@IR(failOn = {IRNode.OOPMAP_WITH, "Foo"}, phase = DEFAULT)
public void mix3() {}

@Test
@IR(counts = {IRNode.STORE, "3"}, phase = AFTER_PARSING)
@IR(counts = {IRNode.STORE_OF_CLASS, "Foo", "3"}, phase = DEFAULT)
@IR(failOn = IRNode.ALLOC, phase = DEFAULT)
@IR(failOn = IRNode.FIELD_ACCESS, phase = DEFAULT)
public void mix4() {}

@Test
Expand All @@ -402,7 +403,7 @@ public void mix5() {}

@Test
@IR(failOn = IRNode.STORE, phase = {PHASEIDEALLOOP1, PHASEIDEALLOOP2})
@IR(counts = {IRNode.ALLOC, "3"}, phase = DEFAULT)
@IR(counts = {IRNode.FIELD_ACCESS, "3"}, phase = DEFAULT)
@IR(failOn = IRNode.STORE, phase = {FINAL_CODE, OPTIMIZE_FINISHED})
public void mix6() {}

Expand All @@ -413,7 +414,7 @@ public void mix7() {}

@Test
@IR(failOn = IRNode.STORE, phase = {PHASEIDEALLOOP1, DEFAULT, PHASEIDEALLOOP2})
@IR(counts = {IRNode.ALLOC, "3"}, phase = {FINAL_CODE, OPTIMIZE_FINISHED, DEFAULT})
@IR(counts = {IRNode.LOOP, "3"}, phase = {FINAL_CODE, OPTIMIZE_FINISHED, DEFAULT})
public void mix8() {}

@Test
Expand All @@ -425,13 +426,13 @@ public void mix9() {}
public void mix10() {}

@Test
@IR(failOn = IRNode.ALLOC, phase = {PHASEIDEALLOOP1, PRINT_OPTO_ASSEMBLY, PHASEIDEALLOOP2})
@IR(failOn = IRNode.ALLOC, phase = {PHASEIDEALLOOP1, PHASEIDEALLOOP2})
@IR(counts = {IRNode.ALLOC, "3"}, phase = {FINAL_CODE, OPTIMIZE_FINISHED, DEFAULT})
public void mix11() {}

@Test
@IR(failOn = IRNode.STORE, phase = {PHASEIDEALLOOP1, PRINT_IDEAL, PHASEIDEALLOOP2})
@IR(counts = {IRNode.ALLOC, "3"}, phase = {FINAL_CODE, OPTIMIZE_FINISHED, DEFAULT})
@IR(counts = {IRNode.LOOP, "3"}, phase = {FINAL_CODE, OPTIMIZE_FINISHED, DEFAULT})
public void mix12() {}

@Test
Expand All @@ -456,7 +457,7 @@ public void mix16() {}

@Test
@IR(counts = {"foo", "3"}, phase = {PHASEIDEALLOOP1, PHASEIDEALLOOP2})
@IR(failOn = IRNode.ALLOC, phase = {FINAL_CODE, OPTIMIZE_FINISHED, DEFAULT})
@IR(failOn = IRNode.LOOP, phase = {FINAL_CODE, OPTIMIZE_FINISHED, DEFAULT})
public void mix17() {}
}
}