Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8352392: AIX: implement attach API v2 and streaming output #24177

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

varada1110
Copy link
Contributor

@varada1110 varada1110 commented Mar 23, 2025

AIX changes for attach API to support arbitrary length arguments and the streaming output support.
serviceability/attach/AttachAPIv2/StreamingOutputTest.java test passes

tier1, tier2 and tier3 testing is successful with fastdebug level

JBS Issue : JDK-8352392


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8352392: AIX: implement attach API v2 and streaming output (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24177/head:pull/24177
$ git checkout pull/24177

Update a local copy of the PR:
$ git checkout pull/24177
$ git pull https://git.openjdk.org/jdk.git pull/24177/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24177

View PR using the GUI difftool:
$ git pr show -t 24177

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24177.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 23, 2025

👋 Welcome back varadam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 23, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title 8352392 AIX: implement attach API v2 and streaming output 8352392: AIX: implement attach API v2 and streaming output Mar 23, 2025
@openjdk
Copy link

openjdk bot commented Mar 23, 2025

@varada1110 The following labels will be automatically applied to this pull request:

  • hotspot-runtime
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 23, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 23, 2025

Webrevs

@JoKern65
Copy link
Contributor

Hi Varada, it looks to me that with your change you've brought the AIX code closer to the POSIX implementation, but not completely. Could you please explain your changes in detail so I can review the PR? I'm not that familiar with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants