Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8352635: Improve inferencing of Float16 operations with constant inputs #24179

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jatin-bhateja
Copy link
Member

@jatin-bhateja jatin-bhateja commented Mar 23, 2025

This is a follow-up PR#22755 to improve Float16 operations inferencing.

The existing scheme to detect Float16 operations for some operations is based on pattern matching which expects to receive inputs through ConvHF2F IR, this patch extends matching to accept constant floating point inputs within the Float16 value range.

Best Regards,
Jatin


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8352635: Improve inferencing of Float16 operations with constant inputs (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24179/head:pull/24179
$ git checkout pull/24179

Update a local copy of the PR:
$ git checkout pull/24179
$ git pull https://git.openjdk.org/jdk.git pull/24179/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24179

View PR using the GUI difftool:
$ git pr show -t 24179

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24179.diff

@jatin-bhateja
Copy link
Member Author

/label add hotspot-compiler-dev

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 23, 2025

👋 Welcome back jbhateja! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 23, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Mar 23, 2025

@jatin-bhateja
The hotspot-compiler label was successfully added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant