Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsoleted PrometheusRSocketClient-based MeterRegistryProvider #954

Merged
merged 5 commits into from
Mar 5, 2025

Conversation

bryceatmoderne
Copy link
Contributor

@bryceatmoderne bryceatmoderne commented Mar 2, 2025

What's changed?

  • removed consumers of PrometheusRSocketClient and related dependencies
  • removed plugin properties rewrite.metricsUri, rewrite.metricsUsername and rewrite.mertricsPassword

What's your motivation?

This dependency is no longer required and indirectly contains a vulnerability from https://mvnrepository.com/artifact/org.xerial.snappy/snappy-java

Anything in particular you'd like reviewers to focus on?

No

Anyone you would like to review specifically?

@knutwannheden

Have you considered any alternatives or workarounds?

No

Any additional context

Vulnerable dependency https://mvnrepository.com/artifact/org.xerial.snappy/snappy-java/1.1.10.1

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@bryceatmoderne bryceatmoderne self-assigned this Mar 2, 2025
Copy link
Contributor

@knutwannheden knutwannheden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • pom.xml
    • lines 199-199

@bryceatmoderne bryceatmoderne changed the title Remove obsoleted prometheus-rsocket-client dependency Remove obsoleted PrometheusRSocketClient-based MeterRegistryProvider Mar 5, 2025
@bryceatmoderne bryceatmoderne merged commit e30c8e7 into main Mar 5, 2025
2 checks passed
@bryceatmoderne bryceatmoderne deleted the remove-prometheus-rsocket-client-dependency branch March 5, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants