Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0-fr1] Add watch to ImageContentSourcePolicy permissions #1289

Open
wants to merge 1 commit into
base: 18.0-fr1
Choose a base branch
from
Open

[18.0-fr1] Add watch to ImageContentSourcePolicy permissions #1289

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1249

/assign bshephar

@bshephar
Add watch to ImageContentSourcePolicy permissions
7b7c07b 
Adding the watch permission will suppress the large number of
errors being reported by the openstack-operator related to watching ICSP
objects.

Jira: https://issues.redhat.com/browse/OSPRH-12713
Signed-off-by: Brendan Shephard <[email protected]>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 4, 2025
Merged
@openshift-ci openshift-ci bot requested review from fultonj and viroel February 4, 2025 23:47
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please ask for approval from bshephar. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bshephar
Copy link
Contributor

bshephar commented Feb 6, 2025

/test openstack-operator-build-deploy-kuttl

1 similar comment
@bshephar
Copy link
Contributor

bshephar commented Feb 6, 2025

/test openstack-operator-build-deploy-kuttl

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 6, 2025

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/openstack-operator-build-deploy-kuttl 7b7c07b link true /test openstack-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@stuggi
Copy link
Contributor

stuggi commented Mar 12, 2025

@bshephar I guess we could close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fultonj fultonj Awaiting requested review from fultonj

@viroel viroel Awaiting requested review from viroel

Assignees

@bshephar bshephar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@openshift-cherrypick-robot @bshephar @stuggi