Refactor python3-observabilityclient package setup in tcib_packages #122
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -16,11 +16,16 @@ tcib_packages: | ||
| - python3-heatclient | ||
| - python3-ironicclient | ||
| - python3-manilaclient | ||
| - python3-octaviaclient | ||
| - python3-aodhclient | ||
| - bash-completion | ||
| - iputils | ||
| #rhel: We can uncomment this when we have rhel specific pkgs | ||
| x86_64: | ||
|
There was a problem hiding this comment. (this one can be removed as discussed yesterday, we don't want/need to distinguish on cpu arch here) |
||
| - python3-observabilityclient | ||
|
There was a problem hiding this comment. This will not install it on centos9 upstream, unless we have something like this https://github.com/openstack-k8s-operators/tcib/blob/main/container-images/tcib/base/os/nova-base/nova-libvirt/nova-libvirt.yaml#L2 here in tcib_actions. The bright side is, it will also not be installed in downstream. There was a problem hiding this comment. does python3-observabilityclient provide an oepnstack client plugin? if not I'm not sure this is strictly in the scope fo this container image. its not intended to have a set of generic debugging clients for example this container is not expect to have ssh or virsh for example to act as a way to debug the comptue nodes or even run must-gather or sosreports. There was a problem hiding this comment. yes, it provides an openstack client plugin. |
||
| el8: | ||
|
There was a problem hiding this comment. how/where are these 'architectures' decided. el8 is operating system specific and x86_64 is cpu architecture specific. how/where is this going to be used There was a problem hiding this comment. So, we had an issue with python3-observabilityclient pkg which we dont need in rhel now - https://redhat-internal.slack.com/archives/C04HN4L5XHV/p1706022079814729. So we want to follow the same pattern we followed with https://opendev.org/openstack/tripleo-common/src/branch/master/container-images/tcib/base/collectd/collectd.yaml#L50 to get this package excluded in rhel. There was a problem hiding this comment. ok thanks for the extra info. as we discussed in yesterday's review call, lets keep only the one we need here (e.g. "el9" or "rhel9" or something similar) and then we will also need some further work to wire it up so that we get the right packages for rhel9 There was a problem hiding this comment. we should not have any el8 related content we will be building this for 9.4 There was a problem hiding this comment. observabilityclient is not built on el8, only for newer releases. |
||
| - python3-observabilityclient | ||
|
|
||
| tcib_user: cloud-admin | ||
| tcib_workdir: /home/cloud-admin | ||
| # If the container is run directly, start an interactive session | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what will be uncommented here?
do you mean more like "we can add rhel specific pkgs to this list"
[EDIT]: ok i see what you mean now. we can uncomment "rhel:" specifically to add a new 'rhel' key and package list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we shoudl not have rhel sepfcic packages in this file this is intended to work on both centos and rhel.
and we do not expect people to edit the file so i dont think this comment is relevent