fix: Cannot read properties of undefined (reading 'getTransform') #766
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Connum
requested changes
Mar 13, 2025
| @@ -161,7 +161,7 @@ <h1>Free Software</h1> | |||
| html += '<dt>leftSideBearing</dt><dd>'+glyph.leftSideBearing+'</dd>'; | |||
| } | |||
| html += '</dl>'; | |||
| if (glyph.numberOfContours > 0) { | |||
| if (glyph.numberOfContours > 0 && window.font.variation) { | |||
There was a problem hiding this comment.
But couldn't there be glyphs with multiple contours but no variation axes? So I think the check for window.font.variation should happen inside, and depending on its availability, either the regular glyph or the transformed variant should be used.
There was a problem hiding this comment.
I’m not very familiar with this professional knowledge. I only encountered this issue during use, so there might be some oversights in the fix. Thank you for pointing it out.
|
Good catch! Please see my review comment! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
close: #765
Types of changes
Checklist:
npm run testand all tests passed green (including code styling checks).