Check admin wallet anoncreds upgrade on startup #3458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jamshale <[email protected]>
|
ianco
approved these changes
Jan 20, 2025
ff137
pushed a commit
to didx-xyz/acapy
that referenced
this pull request
Jan 29, 2025
…n#3458) Signed-off-by: jamshale <[email protected]>
ff137
pushed a commit
to didx-xyz/acapy
that referenced
this pull request
Feb 13, 2025
…n#3458) Signed-off-by: jamshale <[email protected]>
ff137
pushed a commit
to didx-xyz/acapy
that referenced
this pull request
Feb 13, 2025
…n#3458) Signed-off-by: jamshale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed another problem...
The admin wallet in multitenancy mode is allowed to get upgraded through the api endpoint. This is needed because you can only create new sub-wallets which match the base wallet type. However the upgrade check was only checking for sub-wallets. This was a problem if the admin wallet got upgraded because on startup it wouldn't add the wallet to the upgraded singleton and would get 503 on api calls.