Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]: Feat: add JavaScript debugger support #168

Open
wants to merge 74 commits into
base: main
Choose a base branch
from
Open

[WIP]: Feat: add JavaScript debugger support #168

wants to merge 74 commits into from

Conversation

andycall
Copy link
Member

@andycall andycall commented Dec 1, 2022 •
edited
Loading

Closed #77

RFC: https://github.com/openwebf/rfc/blob/main/doc/javascript_debugger.md

Support features:

  1. show current stackTrace.
  2. evaluate any codes in the current scope.
  3. show variables in the current scope.
  4. The debugger statement
  5. both support vscode and Chrome DevTools as client.

TODOs:

  1. debugger core impls
  2. SourceMap support.
  3. Collaborate with WebF devTools server
  4. WebF vscode extension (Debug your Javascript Code in VSCode)
  5. DAP Adaptor to Chrome DevTools Protocol

@andycall andycall changed the title [WIP]: Feat: add Javascript debugger support [WIP]: Feat: add JavaScript debugger support Dec 1, 2022
@andycall andycall mentioned this pull request Jan 15, 2023
Open
@andycall andycall force-pushed the feat/js_debugger_support branch 2 times, most recently from 8551bdb to bb1b136 Compare January 19, 2023 12:56
@NoahJinnn NoahJinnn mentioned this pull request May 12, 2023
Closed
1 task
andycall and others added 25 commits July 20, 2023 13:36
@andycall
feat: add debugger core impls.
6d095d3
@andycall
feat: inject debugger hooks for quickjs runtime.
c54676e
@andycall
feat: add connect api.
809aada
@andycall
feat: add test262 github ci.
f2dc857
@andycall
Committing clang-format changes
10b6626
@andycall
feat: add quickjs test262 test
237fc95
@andycall
chore: fix compile.
ea95f84
@andycall
feat: add inspector test.
b7905d2
@andycall
feat: add communicate methods between inspector server debugger.
4be4660
@andycall
Committing clang-format changes
7258176
@andycall
fix: fix message read.
15c6f84
@andycall
feat: add inspector server.
6be49cb
@andycall
feat: support waiting for debugger attach.
c27329c
@andycall
fix: fix waiting for debugger.
358e9fd
@andycall
feat: generate dap stringify and parser code from typings.
a475005
@andycall
feat: support evaluate scripts with new dap protocol.
f0e809d
@andycall
feat: support customize debugger port.
ad04861
@andycall
feat: rewrite debugger core with dap protocol.
756a65b
@andycall
fix: fix generated dap code.
4c564f8
@andycall
feat: reimpl setBreakspoints with dap.
9640ffa
@andycall
fix: fix crash and add exception breakpoints.
4353e82
@andycall
feat: support set breakpoints from vscode client.
46fb56a
@andycall
chore: remove hashmap.
7b0676d
@andycall
fix: fix empty struct crash.
7b4f914
@andycall
fix: stop at breakpoint now works.
d54e313
andycall and others added 21 commits July 20, 2023 13:36
@andycall
fix: fix expand logging objects in console.
b384407
@andycall
fix: fix get scope variables.
1d8c24c
@andycall
test: add inspector tests.
517b399
@andycall
feat: only attach debugger when client connected.
b63d0c4
@andycall
test: fix inspector test.
be330bf
@andycall
feat: hidden the logging key.
d6b3787
@andycall
test: add more test specs.
130731f
@andycall
test: add full test specs.
076756b
@andycall
fix: fix debugger check called when debugger not attached.
c7e0889
@andycall
feat: add source map polyfill.
73bf4c0
@andycall
feat: add btoa and atob support.
9a66c75
@andycall
Committing clang-format changes
56f3c6a
@andycall
feat: support parse inline source map.
a82772a
@andycall
Committing clang-format changes
85a5d50
@andycall
fix: compact with mimalloc.
19cc392
@andycall
fix: fix exception report.
fee9586
@andycall
fix: fix debugger variables inspection.
57530ec
@andycall
chore: add test debugger tests.
d0ce526
@andycall
fix: fix logger stack trace parsing.
3ae4a7a
@andycall
fix: fix mapped column num.
2144d77
@andycall
fix: sync codes.
93240bc
@andycall andycall force-pushed the feat/js_debugger_support branch from 2cac0ea to 93240bc Compare July 20, 2023 05:44
@andycall andycall self-assigned this Nov 1, 2023
@ammarahm-ed ammarahm-ed mentioned this pull request Nov 22, 2023
Open
@andycall andycall closed this Jan 30, 2024
@p-bakker
Copy link

p-bakker commented Oct 9, 2024

@andycall I see this PR is closed, but the linked issue remains open: has this effort been abandoned?

If so, could you elaborate on why it was abandoned? Am curious if there is a quickjs debugger now or if not whether the work in this PR is worth reviving

@andycall
Copy link
Member Author

I decided to reopen this PR to make it an open-source version feature, but we currently have limited time to implement it.

@andycall andycall reopened this Mar 13, 2025
@andycall
Copy link
Member Author

p

The feature was not abandoned, as rendering and performance in WebF remain our primary focus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@andycall andycall

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add JavaScript Debugger support.
2 participants
@andycall @p-bakker