-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to set size for which parserPopUp prints an inline string. #1112
Add option to set size for which parserPopUp prints an inline string. #1112
Conversation
I have various problems that use drop down menus to fill in the blank in sentences. I do like these being displayed inline in hardcopy rather than a bullet list, hence adding this feature to configure the size this happens, as a few of my cases where just barely over the break point. I thought about maybe using this for a longer list of choices to keep them in line, but ran into another issue where a single line |
This seems fine, although I think that before you have to be strictly less than 25 characters long to get it printed inline, but here it's inline when 25 or less. I didn't test, just reading the code. I may be missing a detail. |
@Alex-Jordan is correct. The previous condition was |
ec71bc3
to
8839e61
Compare
I was aware that I changed the behavior, and even mentioned it in the PR description (as I thought is simplified the logic and the description a bit). I have changed it so now the behavior is the same. |
8839e61
to
a158496
Compare
In hardcopy output, allow the size (number of characters) that an inline string [A/B/C] vs a bullet list is printed to be configurable via a new option inlineSize.
a158496
to
0666f64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no problem with this change, and don't see any reason not to allow it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
In hardcopy output, allow the size (number of characters) that an inline string [A/B/C] vs a bullet list is printed to be configurable via a new option
inlineSize
. Note, this slightly changes the default behavior, if the total characters isinlineSize = 25
, then the list is now inline instead of a bullet list.