Implement default user/group/project quotas including object quotas #17130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
ixhamza
force-pushed
the
NAS-131289
branch
2 times, most recently
from
824f8e8 to
1a5b6e9
Compare
amotin
approved these changes
Mar 10, 2025
|
@ixhamza sorry I've dropped the ball on reviewing this. I'll take a look at it this week. |
|
I did a test where I set It appears that if you delete a file, it doesn't adjust your quota until a few seconds later when the TXG finishes. The 150MB quota I set was exceeded in all my test runs: Setting a defaultuserquota=1M was also exceeded: So quotas seem to be best effort rather than 100% strict, which is probably fine. Setting defaultuserquota=0 seemed to disable quotas. This should be documented in the man pages. Setting copies=2 was correctly accounted for in the quota. 👍 Writing huge xattrs to lots of zero byte files was correctly accounted for in the quota. 👍 |
tonyhutter
reviewed
Mar 27, 2025
Yeah, I observed similar behaviour for non-default user quotas as well. |
This adds default userquota, groupquota, and projectquota properties to MASTER_NODE_OBJ to make them accessible during zfsvfs_init() (regular DSL properties require dsl_config_lock, which cannot be safely acquired in this context). The zfs_fill_zplprops_impl() logic is updated to read these default properties directly from MASTER_NODE_OBJ. Signed-off-by: Ameer Hamza <[email protected]>
Update zfs_id_overobjquota() and zfs_id_overblockquota() to enforce default user/group/project quotas (block and object-based) when no per-user, per-group, or per-project quota exists. If a specific quota is not configured for an ID, the default quota value is applied. Signed-off-by: Ameer Hamza <[email protected]>
Ensure default user/group/project quotas are visible through quota tools and filesystem stats when no per-ID quota is configured. This maintains consistency between quota visibility and configured defaults. Signed-off-by: Ameer Hamza <[email protected]>
Update zfs userspace, groupspace, and projectspace to display the default quotas when no per-ID specific quota is configured. This ensures tool outputs align with enforced limits. Signed-off-by: Ameer Hamza <[email protected]>
Signed-off-by: Ameer Hamza <[email protected]>
Extend test coverage to verify default user and group quota functionality. These build on existing user/group quota tests with additional cases specific to default quotas functionality. Added on top of: openzfs@e08cd97 Signed-off-by: Todd Seidelmann <[email protected]> Signed-off-by: Ameer Hamza <[email protected]>
Extend project quota test coverage to verify defaultprojectquota behavior. These build on existing project quota tests with additional cases specific to defaultprojectquota functionality. Signed-off-by: Ameer Hamza <[email protected]>
Signed-off-by: Ameer Hamza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This change implements default quotas for users, groups, and projects (including object quotas) by extending concepts from Solaris' Default Quotas feature. These defaults guarantee consistent quota enforcement when no per-ID limits are set while ensuring compatibility with existing tools and workflows. This PR is inspired by enhancements proposed in PR #16283.
Fixes: #5431.
Description
This change adds default quota properties to
MASTER_NODE_OBJ, similar to per-ID specific quotas. The functionszfs_id_overobjquota()andzfs_id_overblockquota()have been updated to enforce default limits when no specific per-ID quotas are set. Kernel interfaces for FreeBSD (user/group quotas) and Linux (project quotas) now reflect default quotas to maintain consistency between visibility and configured limits. Thezfs userspace,zfs groupspace, andzfs projectspacecommands display default quotas when no per-ID quotas exist. Newly added tests take motivation from existing per-ID quota tests.How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.