Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simd_powerpc.h: enable FPU on FreeBSD #17191

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

pkubaj
Copy link
Contributor

@pkubaj pkubaj commented Mar 28, 2025

FreeBSD nowadays supports FPU in the kernel on powerpc*, so enable it.

Including machine/pcpu.h needs to be done before including sys/types.h, hence this order.

Motivation and Context

It enables ZFS to use assembly routines with SIMD.

Description

How Has This Been Tested?

Booting with ZFS on root on POWER9 workstation.

FreeBSD 14.2-RELEASE on POWER9, ZFS on /.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@pkubaj pkubaj force-pushed the patch-2 branch 2 times, most recently from 913a112 to 04a2341 Compare March 28, 2025 10:53
@pkubaj pkubaj force-pushed the patch-2 branch 2 times, most recently from 5ed86e8 to cf36060 Compare March 28, 2025 16:36
Copy link
Member

@amotin amotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you've committed it to FreeBSD before waiting for review here. I'll pass it this time, but you haven't even answered to one of my comments, so I assume you know what you are doing and there won't be a followup commit.

@amotin amotin added the Status: Accepted Ready to integrate (reviewed, tested) label Mar 28, 2025
FreeBSD nowadays supports FPU in the kernel on powerpc*, so enable it.

Signed-off-by: Piotr Kubaj <[email protected]>
@pkubaj
Copy link
Contributor Author

pkubaj commented Mar 28, 2025

Sorry, I didn't notice your comment before committing to FreeBSD.
Inclusion of machine/pcpu.h was necessary in the earlier version of the patch but it looks like after I removed some later includes, it's not necessary anymore.

@github-actions github-actions bot removed the Status: Accepted Ready to integrate (reviewed, tested) label Mar 28, 2025
@amotin amotin added the Status: Accepted Ready to integrate (reviewed, tested) label Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants