Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service - add value for External traffic policy #34

Merged
merged 2 commits into from
Mar 9, 2025

Conversation

sbs1990
Copy link
Contributor

@sbs1990 sbs1990 commented Mar 7, 2025

Copy link
Member

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I am assuming the data type is valid. If any notes about min k8s version please add just for passer bys

@codefromthecrypt codefromthecrypt merged commit c6cdc60 into openzipkin:master Mar 9, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants