Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New option to consider acknowledgment at the entity level #2772

Closed
freddidierRTE opened this issue Mar 29, 2022 · 1 comment · Fixed by #2836
Closed

New option to consider acknowledgment at the entity level #2772

freddidierRTE opened this issue Mar 29, 2022 · 1 comment · Fixed by #2836
Assignees
@vlo-rte
Labels
Draft Issue not totally defined

Comments

@freddidierRTE
Copy link
Contributor

freddidierRTE commented Mar 29, 2022 •
edited by vlo-rte
Loading

Add an option in state definition (in config.json) named : consideredAcknowledgedForUserWhen.

This option shall be used to define if a card is considered as acknowledged in the feed or not.

Possible values :

  • userHasAcknowledged
  • oneUserEntityHasAcknowledged
  • allUserEntitiesHasAcknowledged

If the card is sent only to user or group, it is considered acknowledged if user has acknowledged whatever the configuration in state definition.

For testing, use operator4_fr and activity area.

Add in documentation a specific chapter regarding acknowledgement.

This implies to process the acknowledged received via the subscription to update cards in the feed.
@freddidierRTE freddidierRTE added the Draft Issue not totally defined label Mar 29, 2022
@vlo-rte vlo-rte self-assigned this Mar 31, 2022
@vlo-rte vlo-rte changed the title Add an option to consider acknowlegment at the entity level Add an option to consider acknowledgement at the entity level Mar 31, 2022
@vlo-rte
Copy link
Contributor

vlo-rte commented Apr 5, 2022 •
edited
Loading

In order to avoid confusion and after discussion with Frederic, I propose to rename :
userHasAcknowledged -> UserHasAcknowledged
oneUserEntityHasAcknowledged -> OneEntityOfUserHasAcknowledged
allUserEntitiesHasAcknowledged -> AllEntitiesOfUserHaveAcknowledged

vlo-rte added a commit that referenced this issue Apr 5, 2022
@vlo-rte
Add an option to consider acknowledgement at the entity level (#2772)
092f99f 
Signed-off-by: vlo-rte <[email protected]>
@vlo-rte vlo-rte linked a pull request Apr 5, 2022 that will close this issue
New option to consider acknowledgment at the entity level (#2772) #2836
Merged
vlo-rte added a commit that referenced this issue Apr 5, 2022
@vlo-rte
update swagger.yml (#2772)
1e28cd2 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue Apr 8, 2022
@vlo-rte
update for acks in real-time (#2772)
4047869 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue Apr 8, 2022
@vlo-rte
delete of comments (#2772)
ade0e1a 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue Apr 8, 2022
@vlo-rte
update of light-card.component.spec.ts for tests to be ok (#2772)
6aae24a 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue Apr 8, 2022
@vlo-rte
update for cypress tests Acknowledgment.spec.js (#2772)
ab96ab2 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue Apr 8, 2022
@vlo-rte
Add an option to consider acknowledgement at the entity level (#2772)
6dc79e1 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue Apr 8, 2022
@vlo-rte
Add an option to consider acknowledgement at the entity level (#2772)
9c5053f 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue Apr 8, 2022
@vlo-rte
Add an option to consider acknowledgement at the entity level (#2772)
ed7e40c 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue Apr 25, 2022
@vlo-rte
Add an option to consider acknowledgement at the entity level (#2772)
36bc792 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue Apr 27, 2022
@vlo-rte
Add an option to consider acknowledgement at the entity level (#2772)
e280fb9 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue Apr 27, 2022
@vlo-rte
other version : update entitiesAcks in lightcards-store (#2772)
18b7f06 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue Apr 28, 2022
@vlo-rte
Ack filter take into account cards acknowledged by entity(ies) (#2772)
8837392 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue Apr 28, 2022
@vlo-rte
Other version : update entitiesAcks in lightcards-store (#2772)
2b27e8f 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue Apr 28, 2022
@vlo-rte
Ack filter take into account cards acknowledged by entity(ies) (#2772)
ae5e34c 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue Apr 28, 2022
@vlo-rte
update of cypress bundle (#2772)
4986777 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue Apr 28, 2022
@vlo-rte
update of cypress tests for 3 new states (#2772)
1c51b46 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue Apr 29, 2022
@vlo-rte
cypress tests (#2772)
5634ffc 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue Apr 29, 2022
@vlo-rte
cypress tests (#2772)
1551cab 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue May 2, 2022
@vlo-rte
cypress tests for cards sent without entity recipients (#2772)
ca053eb 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue May 2, 2022
@vlo-rte
cypress tests (#2772)
2f91ec4 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue May 2, 2022
@vlo-rte
update of documentation (#2772)
13e00f3 
Signed-off-by: vlo-rte <[email protected]>
@vlo-rte vlo-rte mentioned this issue May 2, 2022
Merged
@vlo-rte vlo-rte changed the title Add an option to consider acknowledgement at the entity level New option to consider acknowledgement at the entity level May 2, 2022
@vlo-rte vlo-rte changed the title New option to consider acknowledgement at the entity level New option to consider acknowledgment at the entity level May 2, 2022
vlo-rte added a commit that referenced this issue May 12, 2022
@vlo-rte
update following review (#2772)
382f6b1 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue May 12, 2022
@vlo-rte
Add an option to consider acknowledgement at the entity level (#2772)
3f99938 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue May 12, 2022
@vlo-rte
Other version : update entitiesAcks in lightcards-store (#2772)
8b4ea15 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue May 12, 2022
@vlo-rte
Ack filter take into account cards acknowledged by entity(ies) (#2772)
c6f9a4d 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue May 12, 2022
@vlo-rte
cypress tests (#2772)
ee2d330 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue May 12, 2022
@vlo-rte
update of documentation (#2772)
462427c 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue May 12, 2022
@vlo-rte
update following review (#2772)
ed1ccfc 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue May 12, 2022
@vlo-rte
update following review (#2772)
5244aba 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue May 12, 2022
@vlo-rte
update following review (#2772)
03e4fbe 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue May 12, 2022
@vlo-rte
update following review (#2772)
46247b6 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue May 12, 2022
@vlo-rte
update following review (#2772)
7bc35fc 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue May 13, 2022
@vlo-rte
Add an option to consider acknowledgement at the entity level (#2772)
619c81b 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue May 13, 2022
@vlo-rte
Other version : update entitiesAcks in lightcards-store (#2772)
dcf9619 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue May 13, 2022
@vlo-rte
Ack filter take into account cards acknowledged by entity(ies) (#2772)
e695543 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue May 13, 2022
@vlo-rte
cypress tests (#2772)
1f4322e 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue May 13, 2022
@vlo-rte
update of documentation (#2772)
7e3c6eb 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue May 13, 2022
@vlo-rte
update following review (#2772)
d1e54f2 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue May 13, 2022
@vlo-rte
update following bug on ack button (#2772)
c77be17 
Signed-off-by: vlo-rte <[email protected]>
vlo-rte added a commit that referenced this issue May 13, 2022
@vlo-rte
Add an option to consider acknowledgement at the entity level (#2772)
9aeb892 
Signed-off-by: vlo-rte <[email protected]>
freddidierRTE pushed a commit that referenced this issue May 13, 2022
@vlo-rte @freddidierRTE
Add an option to consider acknowledgement at the entity level (#2772)
844e401 
Signed-off-by: vlo-rte <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vlo-rte vlo-rte

Labels
Draft Issue not totally defined
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New option to consider acknowledgment at the entity level (#2772) opfab/operatorfabric-core
2 participants
@vlo-rte @freddidierRTE