Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If navigation bar menu has only one entry, show submenu anyway #4451

Closed
freddidierRTE opened this issue Apr 19, 2023 · 2 comments · Fixed by #4623
Closed

If navigation bar menu has only one entry, show submenu anyway #4451

freddidierRTE opened this issue Apr 19, 2023 · 2 comments · Fixed by #4623
Assignees
@vlo-rte
Labels
Enhancement New feature LetsCo Issues needed for letscoordinate project

Comments

@freddidierRTE
Copy link
Contributor

No description provided.

@freddidierRTE freddidierRTE added Enhancement New feature Draft Issue not totally defined labels Apr 19, 2023
@OlivierVoron
Copy link

We need to have a coherent main navbar menus for all the users of the application, only sub-menus are filtered depending on the rights of the user. so if the user has no right to the sub-menus, the menu is not appearing and it is the expected behaviour.
But if the user has only one sub-menu, the actual version 3.14 replace the main navbar menu by the sub-menu and we would like to keep the main menu navbar as this.

@freddidierRTE freddidierRTE added the LetsCo Issues needed for letscoordinate project label Jun 14, 2023
@freddidierRTE
Copy link
Contributor Author

freddidierRTE commented Jun 14, 2023 •
edited by vlo-rte
Loading

This behavior shall be optional , with a boolean param in the ui-menu.json : showDropdownMenuEvenIfOnlyOneEntry :

Defaut value is false

@freddidierRTE freddidierRTE removed the Draft Issue not totally defined label Jun 14, 2023
@vlo-rte vlo-rte assigned vlo-rte and unassigned vlo-rte Jun 16, 2023
@vlo-rte vlo-rte changed the title If navbar menu has one entry , show submenu anyway If navigation bar menu has only one entry, show submenu anyway Jun 16, 2023
vlo-rte added a commit that referenced this issue Jun 16, 2023
@vlo-rte
If navigation bar menu has only one entry, show submenu anyway (#4451)
f5eb180 
Signed-off-by: vlo-rte <[email protected]>
@vlo-rte vlo-rte mentioned this issue Jun 16, 2023
Merged
@vlo-rte vlo-rte linked a pull request Jun 16, 2023 that will close this issue
If navigation bar menu has only one entry, show submenu anyway (#4451) #4623
Merged
vlo-rte added a commit that referenced this issue Jun 16, 2023
@vlo-rte
If navigation bar menu has only one entry, show submenu anyway (#4451)
268c096 
Signed-off-by: vlo-rte <[email protected]>
@vlo-rte vlo-rte self-assigned this Jun 16, 2023
@vlo-rte vlo-rte moved this from 🔖 Ready to 🏗 In progress in OperatorFabric Release 4.0.0 Jun 16, 2023
@vlo-rte vlo-rte moved this from 🏗 In progress to 👀 In review in OperatorFabric Release 4.0.0 Jun 16, 2023
vlo-rte added a commit that referenced this issue Jun 19, 2023
@vlo-rte
If navigation bar menu has only one entry, show submenu anyway (#4451)
cd73c9a 
Signed-off-by: vlo-rte <[email protected]>
freddidierRTE pushed a commit that referenced this issue Jun 21, 2023
@vlo-rte @freddidierRTE
If navigation bar menu has only one entry, show submenu anyway (#4451)
3eb3347 
Signed-off-by: vlo-rte <[email protected]>
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in OperatorFabric Release 4.0.0 Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vlo-rte vlo-rte

Labels
Enhancement New feature LetsCo Issues needed for letscoordinate project
Projects
No open projects
OperatorFabric Release 4.0.0
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

If navigation bar menu has only one entry, show submenu anyway (#4451) opfab/operatorfabric-core
3 participants
@vlo-rte @freddidierRTE @OlivierVoron