Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In usercard add a checkbox to keep child card #6669

Closed
freddidierRTE opened this issue Jun 18, 2024 · 0 comments · Fixed by #6754
Closed

In usercard add a checkbox to keep child card #6669

freddidierRTE opened this issue Jun 18, 2024 · 0 comments · Fixed by #6754
Assignees
Labels
Enhancement New feature

Comments

@freddidierRTE
Copy link
Contributor

freddidierRTE commented Jun 18, 2024

The objective is to offer the user the choice to keep existing response, if any, when editing a card

  • The option appears on edition mode if there is already one or more child cards
  • The option appears only if the state (in config.json) has the parameter userCard.keepChildCardsVisible set to true (default value is false)
  • This checkbox is checked by default
  • The label of the checkbox shall be "keep existing responses"
  • The label in french shall be "Conserver les réponses existantes"

Implementation

  • Like for severity, create a class keepchildCardForm.ts in ui/main/src/app/business/view/userCard/keepchildCardsForm
  • Use setInputVisibility in UserCardUIControl to set field visibility
  • Add unit test in ui/main/src/app/business/view/userCard/userCard.view.spec.ts (see "Get ChildCard for preview " and "Send card tests"
  • Adjust or add an existing cypress test to check the option is present and the checkbox selected and send card
  • Add new config option keepChildCardsVisible in src/test/api/karate/businessconfig/getABusinessconfig.feature
@freddidierRTE freddidierRTE added the Enhancement New feature label Jun 18, 2024
@freddidierRTE freddidierRTE changed the title In built-in question add a checkbox to keep child card In usercard add a checkbox to keep child card Jun 19, 2024
ClementBouvierN added a commit that referenced this issue Jul 9, 2024
@ClementBouvierN ClementBouvierN linked a pull request Jul 9, 2024 that will close this issue
ClementBouvierN added a commit that referenced this issue Jul 9, 2024
ClementBouvierN added a commit that referenced this issue Jul 9, 2024
ClementBouvierN added a commit that referenced this issue Jul 17, 2024
ClementBouvierN added a commit that referenced this issue Jul 17, 2024
ClementBouvierN added a commit that referenced this issue Jul 17, 2024
ClementBouvierN added a commit that referenced this issue Jul 17, 2024
ClementBouvierN added a commit that referenced this issue Jul 17, 2024
ClementBouvierN added a commit that referenced this issue Jul 17, 2024
freddidierRTE pushed a commit that referenced this issue Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants